Page MenuHomePhabricator

Following a link which can't be handled on the device crashes the app
Closed, ResolvedPublic

Description

Try a worldwind:// link for example.


Version: Android (alpha)
Severity: normal

Details

Reference
bz64424

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:21 AM
bzimport set Reference to bz64424.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to Liangent from comment #0)

Try a worldwind:// link for example.

This doesn't crash the app for more, but it does cause it to just sit there with the spinner spinning until you press back or go to another page.

This is also sort of an iOS bug, as when you click the link on iOS nothing happens, which is pretty bad considering the user has no idea why the link isn't loading; the fact the link is meaningless isn't obvious to you from the text that displays.

A message saying that displays the link and says that the app can't handle it would probably be the best solution for iOS and Android.

(In reply to Dan Garry from comment #1)

This doesn't crash the app for more, but it does cause it to just sit there
with the spinner spinning until you press back or go to another page.

Still crashing for me .. latest Google Play alpha release.

Is this still the case? I can't find any link that crashes the app.

Change 134281 had a related patch set uploaded by Yuvipanda:
Fix crashing when handling an unprocessable external link

https://gerrit.wikimedia.org/r/134281

Just shows a small toast saying this link can't be opened.

Change 134281 merged by jenkins-bot:
Fix crashing when handling an unprocessable external link

https://gerrit.wikimedia.org/r/134281