Page MenuHomePhabricator

Inappropriate UA sniffing in edit toolbar code.
Closed, ResolvedPublic

Description

Author: maksim

Description:
Hi...

Currently, the editing toolbar on WikiPedia is guarded by the following:
if (!document.selection && !is_gecko) {

which disables the functionality on browsers other than IE and Mozilla family. However,
the functionality it relies on, textarea.selectionStart/.selectionEnd is supported in
other browsers families as well. I've implemented it in konqueror for 3.5.2, there is an
independent implementation in development builds of Safari, and Opera 9 preview 1 appears
to support it too. It would be appreciated if this test used object-detection insread, so
non-mozilla/non-IE users weren't locked out of this functionality.

Thanks.


Version: unspecified
Severity: normal
OS: Linux
Platform: Other

Details

Reference
bz4921

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:06 PM
bzimport set Reference to bz4921.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of 4663 ***