Page MenuHomePhabricator

[iOS] Table of Contents sidebar shows as empty space with locale set to Arabic
Closed, ResolvedPublic

Description

It seems that some combination of the layout flipping in RTL locales and our magic ToC sidebar logic isn't working.

Steps:

  • set phone to arabic
  • press ToC button (or swipe in)

Expected:

  • sidebar should slide in from the right (opposite side from usual)
  • ToC should be visible

Actual:

  • empty gray space slides in from the right (opposite side from usual)
  • no ToC is visible

Additionally we might want to switch the direction of the swipe detection when locale is RTL.


Version: Alpha
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:40 AM
bzimport set Reference to bz67610.
bzimport added a subscriber: Unknown Object (MLST).
brion created this task.Jul 7 2014, 6:12 PM
brion added a comment.Jul 15 2014, 6:55 PM

Monte got this the other day.

Change 207797 had a related patch set uploaded (by Sbisson):
Fix history permission check in RevisionFormatter

https://gerrit.wikimedia.org/r/207797

Change 207797 merged by jenkins-bot:
Fix history permission check in RevisionFormatter

https://gerrit.wikimedia.org/r/207797