Page MenuHomePhabricator

Update API gem to handle action=tokens deprecation
Closed, ResolvedPublic

Description

As of 26 August all tests using the API are failing:

13:42 chrismcmahon: hmm, breaking change to the API? {"tokens"=>{"*"=>"action=tokens has been deprecated. Please use action=query&meta=tokens instead."}}
13:42 legoktm: Deskana: https://gerrit.wikimedia.org/r/#/c/144644/
13:42 legoktm: chrismcmahon: yes there was an announcement
13:43 legoktm: nothing is broken though
13:43 legoktm: chrismcmahon: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2014-August/000067.html
13:43 chrismcmahon: thanks legoktm that's ummm annoying
13:43 legoktm: why?
13:45 chrismcmahon: I've never heard of Mediawiki-api-announce before, oh well.
13:45 legoktm: there's also mediawiki-api too
13:45 chrismcmahon: nor suspected that I should subscribe to it had I known it existed. anyway, I can fix the issue
13:46 legoktm: the list is listed at https://www.mediawiki.org/wiki/API:Main_page#Useful_links, please add links to it in other places too :)


Version: wmf-deployment
Severity: normal

Details

Reference
bz70066

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:29 AM
bzimport set Reference to bz70066.

First things first, the API client should be refactored to not fail upon a deprecation warning. We can then look into how to best implement the new meta=tokens query (and what condition to switch on; AFAICT, the API endpoint is not versioned).

gerritadmin wrote:

Change 156480 had a related patch set uploaded by Dduvall:
Fixed token error handling

https://gerrit.wikimedia.org/r/156480

gerritadmin wrote:

Change 156480 merged by jenkins-bot:
Fixed token error handling

https://gerrit.wikimedia.org/r/156480