Page MenuHomePhabricator

Single quotes in RSS field cause issues
Closed, DeclinedPublic

Description

Author: axelseaa

Description:
The single quotes used to include the rss/atom links in line 878 and 880 of
includes/OutputPage.php cause firefox to not detect that there is a feed on the
page. This may affect other things as well.

The fix is to just change the linkes to use " as follows:

878:
$ret .= "<link rel=\"alternate\" type=\"application/rss+xml\" title=\"RSS 2.0\"
href=\"$link\" />\n";

880:
$ret .= "<link rel=\"alternate\" type=\"application/atom+xml\" title=\"Atom
0.3\" href=\"$link\" />\n";


Version: 1.5.x
Severity: normal
Platform: PC

Details

Reference
bz5374

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:10 PM
bzimport set Reference to bz5374.
bzimport added a subscriber: Unknown Object (MLST).

Firefox 1.5 sees the RSS feed and shows it's little orange link
in the URL bar at eg http://en.wikipedia.org/wiki/Special:Recentchanges.

If you have some odd version of Firefox where this doesn't work,
you can report bugs to the Mozilla team at http://bugzilla.mozilla.org/

axelseaa wrote:

I have also tested this, and it seems to work.

Change 695845 had a related patch set uploaded (by RhinosF1; author: RhinosF1):

[mediawiki/extensions/Comments@master] Per suggestion at https://phabricator.miraheze.org/T7374#147024

https://gerrit.wikimedia.org/r/695845