Page MenuHomePhabricator

A block link is shown in the new users log
Closed, ResolvedPublic

Description

Author: rotemliss

Description:
A block link is shown in the comment of the log also for non-sysops. There is no
way to differ the comments for sysops and for non-sysops, so I suggest to remove
this link. (All these links are actually redundant for the links in the Recent
Changes are shown, and when those links will be added also to Special:Log, we
will be able to remove them from the log entry, and leave only "New user".)

A patch is coming soon.


Version: unspecified
Severity: trivial

Details

Reference
bz5621

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:12 PM
bzimport set Reference to bz5621.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

Patch

The patch just removes the block link.

attachment 1.patch ignored as obsolete

rotemliss wrote:

Mmm, the code I've used is old. Please wait a minute.

rotemliss wrote:

Patch v2

Now the patch is updated. This patch removes "Block", and in addition, removes
"newuserloglog" (it was said "for compatibility", but the text created from
this message is stored in the database, and we don't use it anymore). Also, it
fixes the following comments:
Compatibility entries.
Old code stored Special:Userlogin as the target, not very helpful.
to:
// Old log entries (real content was in field "log_comment" in the database)
because the comment about the fact "Special:Userlogin" was stored may be
interesting, but how does it help for those who want to understand the code?

Attached:

Will not accept this patch.

Would perhaps accept some fixes to the log system allowing it to
display alternate forms for the user, but it's not really
necessary.

rotemliss wrote:

(In reply to comment #4)

Will not accept this patch.

Why not? We have the same links in Special:Recentchanges, if we want to block
him immediantly. I also will suggest to add such links also to Special:Log, so
we won't need all of these links anymore.

robchur wrote:

Such links are now present in log pages.