Page MenuHomePhabricator

Don't load MMV if oojs isn't going to work
Closed, ResolvedPublic

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/574

2014-07-10 - 10:33:14 <marktraceur> OK so
2014-07-10 - 10:33:35 <marktraceur> I'm just going to close https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/574 as invalid
2014-07-10 - 10:33:37 <marktraceur> Sound sane?
2014-07-10 - 10:33:39 <+Krinkle> marktraceur: so, 1) skipFunction is probably not what you want, and 2) is loading because you asked us to support ES3, it is never skipped.
2014-07-10 - 10:33:49 <+Krinkle> oojs that is
2014-07-10 - 10:34:09 <+James_F> marktraceur: Yes. 574 sounds like "If the world has ended, still try to work".
2014-07-10 - 10:34:13 <marktraceur> If OOUI fails I think we already skip loading the things that use it
2014-07-10 - 10:34:19 <+Krinkle> The title of that bug conflicts with the enhancements "OOjs should support IE8" and "OOjs should support ES3"
2014-07-10 - 10:34:22 <+Krinkle> we even support IE6 now
2014-07-10 - 10:35:06 <+Krinkle> marktraceur: yep close as invalid because oojs is always gonna work
2014-07-10 - 10:35:16 <marktraceur> K

Event Timeline

MingleTerminator raised the priority of this task from to High.