Page MenuHomePhabricator
Create Task
Maniphest T8358

SpecialAllpages.php - redundant variables
Closed, ResolvedPublic
Actions

Description

Author: Shtriter

Description:
$page $fromwhere $order_arr and $order_str variables are defined in SpecialAllpages.php
(lines 93-96) but not used. Special:Allpages works fine when they are deleted.

Version: unspecified
Severity: enhancement
OS: Windows XP
Platform: PC

Details

Reference
bz6358

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 9:19 PM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz6358.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jun 18 2006, 1:32 PM
• bzimport added a comment.Jun 18 2006, 1:36 PM

Shtriter wrote:

Possible reason is the use of $dbr->selectField(...) function. So I guess that
these vars were forgotten when new DB access approach was introduced.

• bzimport added a comment.Jul 7 2006, 11:12 AM

rotemliss wrote:

r15405.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL