Author: mediazilla

Description:
If I set $wgLanguageCode in LocalSettings.php then I expect the value set to be
respected. That is, if I specifically make the effort to set it to be "fr" in
LocalSettings.php, I expect, when I refer to $wgLanguageCode, to get the value
"fr". This is not the case.

As it is, when I set it, sometimes it IS respected (for example, when I run the
maintenance/rebuildMessages.php) but at other times (for example, if I naively
use $wgLanguageCode as a variable and expect it to correspond to what I have
explicitly set in LocalSettings.php).

To some degree, it seems simply "working as designed" since the code in
"Setup.php" seems to make the concious decision to take the value from the
current user. However, there seems to be something screwy about the logic that
a user can set a value in LocalSettings which is then blatently ignored.

<?php

$IP = "c:\\program files\\apache group\\www\\chainki dev";
ini_set( "include_path", ".;$IP;$IP/includes;$IP/languages;$IP/wikilink/class" );

define( 'MEDIAWIKI', true );

require_once("../includes/Defines.php");
require_once("../includes/DefaultSettings.php");
require_once("../LocalSettings.php");
echo("after LocalSettings, wgLanguageCode=$wgLanguageCode<br>");

require_once("../includes/Setup.php");
echo("after Setup, wgLanguageCode=$wgLanguageCode<br>");

?>

The above code, with $wgLanugageCode = "fr" in LocalSettings.php, but with an

"en" user gives:

after LocalSettings, wgLanguageCode=fr
after Setup, wgLanguageCode=en
Finally, wgLanguageCode=en

From "includes/Setup.php"
<?php
// wgLanguageCode now specifically means the UI language
$wgLanguageCode = $wgRequest->getText('uselang', '');
if ($wgLanguageCode == '')
$wgLanguageCode = $wgUser->getOption('language');

Validate $wgLanguageCode, which will soon be sent to an eval()

if( empty( $wgLanguageCode ) || !preg_match( '/^[a-z]+(-[a-z]+)?$/',
$wgLanguageCode ) ) {
$wgLanguageCode = $wgContLanguageCode;
}
?>

What to do? It seems to me that there are 2 fundamentally diffent language
codes represented here: the language code used to build the messages and the
language code of the user. Unfortunately both of these seem to be tried to be
stored in the same global variable. The solution I imagine is to seperate the
two: keep $wgLanguageCode to represent the current user language code (and this
would NOT ever be in DefaultSettings, nor therefore ever in LocalSettings), and
a user configurable language code, e.g. $wgMessageLanguage.

Version: 1.5.x
Severity: normal
OS: Windows XP
Platform: PC