Page MenuHomePhabricator

More descriptive Cite.php error messages
Closed, ResolvedPublic

Description

Author: ayg

Description:
The current Cite.php user errors are:

'Invalid call; expecting a non-integer key'
'Invalid call; no key specified'
'Invalid call; invalid keys, e.g. too many or wrong key specified'
'Invalid call; no input specified'
'Invalid input; expecting none'
'Invalid parameters; expecting none'
"Ran out of custom backlink labels, define more in the
\"''cite_references_link_many_format_backlink_labels''\" message"

I don't think these are probably very understandable to non-techy types.
(What's a "call"? "Key"? For that matter, what's "Cite"? Etc.) May I suggest
they're changed (lines 77-83 of Cite.php) to something more like:

'Invalid <code>&lt;ref&gt;</code> tag; name cannot be a simple integer'
'Invalid <code>&lt;ref&gt;</code> tag; refs with no content must have a name,
see http://meta.wikimedia.org/wiki/Cite/Cite.php'
'Invalid <code>&lt;ref&gt;</code> tag; invalid names, e.g. too many'
'Invalid <code>&lt;ref&gt;</code> tag; refs with no name must have content, see
http://meta.wikimedia.org/wiki/Cite/Cite.php'
'Invalid <code>&lt;references&gt;</code> tag; no input is allowed, use
<code>&lt;references /&gt;</code>'
'Invalid <code>&lt;references&gt;</code> tag; no parameters are allowed, use
<code>&lt;references /&gt;</code>'
"Ran out of custom backlink labels, ask an administrator to define more in the
\"''cite_references_link_many_format_backlink_labels''\" message"


Version: unspecified
Severity: enhancement

Details

Reference
bz6554

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:18 PM
bzimport added a project: Cite.
bzimport set Reference to bz6554.
bzimport added a subscriber: Unknown Object (MLST).

ayg wrote:

Fixed in r16960 (see also r16961).