Page MenuHomePhabricator
Create Task
Maniphest T88150

Activation of Fixed header misaligns content translation search suggestion box
Closed, InvalidPublic
Actions

Description

To reproduce :

  1. Activate "Fixed header" beta feature.
  2. Go to Content Translation page
  3. Click on "Create new Translation"
  4. Type in "Search for source page"

The suggestions box is displayed under logout link.

Details

SubjectRepoBranchLines +/-
Fixed suggestion box alignment on activation of fixed headermediawiki/coremaster+6 -0
Fixed suggestion box alignment on activation of fixed headermediawiki/extensions/VectorBetamaster+5 -5
Customize query in gerrit

Event Timeline

Phoenix303 created this task.Jan 30 2015, 8:31 PM
Phoenix303 raised the priority of this task from to Needs Triage.
Phoenix303 updated the task description. (Show Details)
Phoenix303 added a project: MediaWiki-extensions-VectorBeta.
Phoenix303 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:31 PM
Phoenix303 renamed this task from Activating Fixed header misaligns content translation search suggestion box to Activation of Fixed header misaligns content translation search suggestion box.Jan 30 2015, 10:26 PM
Phoenix303 triaged this task as Medium priority.
Phoenix303 set Security to None.
Phoenix303 added a comment.Feb 3 2015, 12:03 AM

Fixed header not only misaligns content translation suggestion box but all the suggestion boxes. This is happening due to suggestions style override.

I am working on this bug and would like to propose my solution for the same. I was thinking to add class, say "searchInputFixed" to only fixed suggestions box and then override only suggestions style with "searchInputFixed" class.

Please let me know about my solution and any alternative to this.

gerritbot subscribed.Feb 20 2015, 4:14 AM

Change 191847 had a related patch set uploaded (by Phoenix303):
Fixed suggestion box alignment on activation of fixed header

https://gerrit.wikimedia.org/r/191847

Patch-For-Review

gerritbot added a comment.Feb 20 2015, 4:15 AM

Change 191848 had a related patch set uploaded (by Phoenix303):
Fixed suggestion box alignment on activation of fixed header

https://gerrit.wikimedia.org/r/191848

Patch-For-Review

Aklapper added a project: Patch-For-Review.Feb 20 2015, 12:27 PM
Liuxinyu970226 subscribed.May 20 2015, 10:56 PM
gerritbot added a comment.Dec 31 2015, 5:21 AM

Change 191848 abandoned by Phoenix303:
Fixed suggestion box alignment on activation of fixed header

https://gerrit.wikimedia.org/r/191848

gerritbot added a comment.Dec 31 2015, 5:21 AM

Change 191847 abandoned by Phoenix303:
Fixed suggestion box alignment on activation of fixed header

https://gerrit.wikimedia.org/r/191847

Phoenix303 closed this task as Invalid.Dec 31 2015, 5:24 AM
Phoenix303 claimed this task.
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptDec 31 2015, 5:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits