Page MenuHomePhabricator
Create Task
Maniphest T88597

move misc mw maintenance scripts into mw puppet module
Closed, ResolvedPublic
Actions

Description

we would like to get rid of the entire 'misc' directory in the operations/puppet repo.

misc/maintenance.pp is one of the bigger ones left.

maintenance.pp contains all those mw related scripts and crons. so the idea is to move them into the mediawiki module instead of sitting here in /misc unrelated.

i started a patch for that here https://gerrit.wikimedia.org/r/#/c/178873/

could platform engineering / Ori / Reedy / anyone take a look ?

this feels a bit touchy because it can potentially influence all the maintenance crons at once.

also, is this a good moment to check if any of these scripts are not being used anymore that can be removed?

Details

SubjectRepoBranchLines +/-
delete misc/maintenance.pp, now emptyoperations/puppetproduction+0 -0
Customize query in gerrit

Related Objects

Event Timeline

Dzahn created this task.Feb 4 2015, 8:48 PM
Dzahn raised the priority of this task from to Needs Triage.
Dzahn updated the task description. (Show Details)
Dzahn added projects: acl*sre-team, MediaWiki-Core-Team.
Dzahn subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2015, 8:48 PM
Dzahn updated the task description. (Show Details)Feb 4 2015, 8:51 PM
Dzahn set Security to None.
Dzahn triaged this task as Medium priority.Feb 5 2015, 1:23 AM
bd808 removed a project: MediaWiki-Core-Team.Apr 8 2015, 10:44 PM
Dzahn claimed this task.Sep 15 2015, 6:59 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 15 2015, 6:59 PM
Dzahn mentioned this in rOPUPf2d9cc94d198: move mediawiki maintenance scripts to module.Sep 15 2015, 10:24 PM
Dzahn added a comment.Sep 15 2015, 10:33 PM

I merged this:

https://gerrit.wikimedia.org/r/178873

compiler result was here:

http://puppet-compiler.wmflabs.org/891/terbium.eqiad.wmnet/

also checked the run on terbium and compared crontabs of mwdeploy and www-data before and after, identical

Dzahn added a comment.Sep 15 2015, 10:40 PM

all the maintenance jobs are here now:

/puppet/modules/mediawiki/manifests/maintenance$ ls
cleanup_upload_stash.pp  purge_checkuser.pp   translationnotifications.pp  updatetranslationstats.pp
echo_mail_batch.pp       purge_securepoll.pp  update_article_count.pp      wikidata.pp
pagetriage.pp            README.md            update_flaggedrev_stats.pp
parsercachepurging.pp    refreshlinks.pp      updatequerypages.pp
purge_abusefilter.pp     tor_exit_node.pp     update_special_pages.pp

misc/maintenance.pp is gone
gerritbot subscribed.Sep 15 2015, 10:43 PM

Change 238626 had a related patch set uploaded (by Dzahn):
delete misc/maintenance.pp, now empty

https://gerrit.wikimedia.org/r/238626

gerritbot added a project: Patch-For-Review.Sep 15 2015, 10:43 PM

Change 238626 merged by Dzahn:
delete misc/maintenance.pp, now empty

https://gerrit.wikimedia.org/r/238626

Dzahn mentioned this in rOPUP9669ffacf875: delete misc/maintenance.pp, now empty.Sep 15 2015, 10:45 PM
Dzahn closed this task as Resolved.Sep 15 2015, 10:45 PM
Dzahn removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits