Page MenuHomePhabricator

Specify table background to be the same as page background
Closed, ResolvedPublic


Author: ayg

After finally getting the devs to set table backgrounds to transparent so they
didn't look awful on special pages like [[Special:Movepage]], per bug 3582, I
discovered the probable reason for why they were specified as white in Monobook
in the first place: if they're transparent, level-one and -two heading rules
(actually border-bottoms) run into them, as can be seen at the provided URL.

Mea culpa. Tables should be set back to white, and projects that modify the
background colors should modify the background colors of any
background-color-specified descendants as well (#content table { background:
#F8FCFF } .ns-0 * #content table { background: white; } for enwiki).

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:16 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz6918.
bzimport added a subscriber: Unknown Object (MLST).

ayg wrote:

One-line patch

attachment 6918a.patch ignored as obsolete

ayg wrote:

Patch with comment

Actually, let's not cause the same confusion that resulted in this problem
coming up in the first place. There's a reason God invented comments.


ayg wrote:

Fixed in r16956 (see also r16957).