Page MenuHomePhabricator

Replace hard-coded empty message checks with wfEmptyMsg
Closed, ResolvedPublic


Author: dto

SkinTemplate checks for empty messages using <[msg]> instead of wfEmptyMsg.

Not a big deal, but who knows, wfMsg might start returning some other default
message in the future.

Version: 1.8.x
Severity: trivial



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:25 PM
bzimport set Reference to bz7064.
bzimport added a subscriber: Unknown Object (MLST).

dto wrote:

patch for r16128 to have SkinTemplate use wfEmptyMsg

attachment skintemplate.diff ignored as obsolete

robchur wrote:

A lot of code does this; SkinTemplate.php is not unique in this respect.

dto wrote:

I just happened to see that, looking over SkinTemplate.php. Is there any attempt
to correct this kind of hard-coding in other places?

dto wrote:


I think I found them all...