Page MenuHomePhabricator

Extended toolbar bug in Opera
Closed, DeclinedPublic

Description

We use extended toolbar with javascript buttons in ru.wikisource and
fr.wikisource. But Where is bug in Opera browser with tags in javascript.

The bug appeared after r14419.


Version: 1.8.x
Severity: minor
URL: http://ru.wikisource.org/w/index.php?title=User:.:Ajvol:.&action=edit

Details

Reference
bz7211

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:28 PM
bzimport set Reference to bz7211.
bzimport added a subscriber: Unknown Object (MLST).

revert

Attached:

This probably comes from using innerHTML, which is very very unreliable.
Instead, try using the JS function for adding toolbar buttons.

But so I can not add button with javascript function (wikifikator, add table) on
click.

I have no idea what that means, but I assume it means "JavaScript functions can't be run
in response to UI events" which I'm pretty sure is not true. ;)

try using the JS function for adding toolbar buttons

Which functions?

I know only about "mwCustomEditButtons" array, but i can not use it for:

<a href="javascript:Wikificator();"><img src="http://...button.png" \></a>

I know 2 ways to solve this problem:

  1. something like in

http://fr.wikikipedia.org/wiki/MediaWiki:Monobook.js
but in this case i can add button with javascript function on click only at
first position in toolbar (edit any article en fr.wikipedia). It is because
CDATA javascript in <div id='toolbar'>.

  1. or something like in

http://fr.wikisource.org/wiki/MediaWiki:Monobook.js

it is good, but not for Opera browser. And so i create this patch.

Pardonu mian anglan :(