Page MenuHomePhabricator
Create Task
Maniphest T98082

Searching via API in current master can result in exception
Closed, ResolvedPublic
Actions

Description

[fatal] [8191ba1c] /w/api.php?action=query&cirrusBoostLinks=yes&format=json&formatversion=2&list=search&sroffset=&srprop=snippet%7Ctitlesnippet%7Credirectsnippet%7Csectionsnippet%7Ccategorysnippet%7Cisfilematch&srsearch=all%3ARelevancynamespacetest&uselang= ErrorException from line 219 of /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/Searcher.php: PHP Error: Argument 3 passed to CirrusSearch\Searcher::construct() must be an instance of array, null given
#0 /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/Searcher.php(219): MWExceptionHandler::handleError()
#1 /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/CirrusSearch.php(75): CirrusSearch\Searcher->construct()
#2 /srv/vagrant/mediawiki/includes/api/ApiQuerySearch.php(110): CirrusSearch->searchText()
#3 /srv/vagrant/mediawiki/includes/api/ApiQuerySearch.php(47): ApiQuerySearch->run()
#4 /srv/vagrant/mediawiki/includes/api/ApiQuery.php(286): ApiQuerySearch->execute()
#5 /srv/vagrant/mediawiki/includes/api/ApiMain.php(1098): ApiQuery->execute()
#6 /srv/vagrant/mediawiki/includes/api/ApiMain.php(436): ApiMain->executeAction()
#7 /srv/vagrant/mediawiki/includes/api/ApiMain.php(409): ApiMain->executeActionWithErrorHandling()
#8 /srv/vagrant/mediawiki/api.php(90): ApiMain->execute()
#9 /var/www/w/api.php(5): include()
#10 {main}

Details

SubjectRepoBranchLines +/-
Document namespaces member as nullablemediawiki/coremaster+2 -2
Null is a valid value in Searcher::$namespacesmediawiki/extensions/CirrusSearchmaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

EBernhardson created this task.May 4 2015, 10:05 PM
EBernhardson raised the priority of this task from to High.
EBernhardson updated the task description. (Show Details)
EBernhardson added a project: CirrusSearch.
EBernhardson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2015, 10:05 PM
gerritbot subscribed.May 4 2015, 10:06 PM

Change 208825 had a related patch set uploaded (by EBernhardson):
Document namespaces member as nullable

https://gerrit.wikimedia.org/r/208825

gerritbot added a project: Patch-For-Review.May 4 2015, 10:06 PM
gerritbot added a comment.May 4 2015, 10:09 PM

Change 208827 had a related patch set uploaded (by EBernhardson):
Don't pass null to constructor that requires array

https://gerrit.wikimedia.org/r/208827

EBernhardson raised the priority of this task from High to Unbreak Now!.May 4 2015, 10:13 PM
EBernhardson added a project: Discovery-ARCHIVED.
EBernhardson set Security to None.
gerritbot added a comment.May 5 2015, 12:08 AM

Change 208827 merged by jenkins-bot:
Null is a valid value in Searcher::$namespaces

https://gerrit.wikimedia.org/r/208827

EBernhardson mentioned this in rMEXT0f38cfda8ab8: Updated mediawiki/extensions Project: mediawiki/extensions/CirrusSearch….May 5 2015, 12:08 AM
EBernhardson mentioned this in rECIR6b2a5f63c2cb: Null is a valid value in Searcher::$namespaces.May 5 2015, 12:24 AM
• Manybubbles moved this task from Needs triage to Done on the Discovery-ARCHIVED board.May 5 2015, 5:21 PM
gerritbot added a comment.May 5 2015, 6:22 PM

Change 208825 merged by jenkins-bot:
Document namespaces member as nullable

https://gerrit.wikimedia.org/r/208825

EBernhardson mentioned this in rMW28abb2620adc: Document namespaces member as nullable.May 5 2015, 6:22 PM
• Manybubbles closed this task as Resolved.May 7 2015, 7:17 PM
• Manybubbles assigned this task to EBernhardson.
• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Dec 31 2015, 5:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL