Page MenuHomePhabricator
Create Task
Maniphest T98786

CirrusSearch: Stop logging an error when I user sends a prefix query that is too long
Closed, ResolvedPublic
Actions

Description

They look like:
UsageException from line 1517 of /srv/mediawiki/php-1.26wmf4/extensions/CirrusSearch/includes/Searcher.php: Prefix search request was longer than the maximum allowed length. (1210 > 255)

Its nice that the user gets the error but we don't want to log the exception because its noisy.

Details

SubjectRepoBranchLines +/-
Don't leak UsageException in non-api code pathsmediawiki/extensions/CirrusSearchmaster+21 -2
Make UsageException explicitly not loggablemediawiki/coremaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

• Manybubbles created this task.May 11 2015, 9:27 PM
• Manybubbles raised the priority of this task from to Medium.
• Manybubbles updated the task description. (Show Details)
• Manybubbles added projects: Discovery-ARCHIVED, Discovery-Search (Current work).
• Manybubbles moved this task to Search on the Discovery-ARCHIVED board.
• Manybubbles subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2015, 9:27 PM
EBernhardson claimed this task.May 11 2015, 10:31 PM
EBernhardson set Security to None.

These look to be because we are throwing an API specific exception (UsageException) from a special page.

EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.May 11 2015, 10:31 PM
gerritbot subscribed.May 11 2015, 11:03 PM

Change 210235 had a related patch set uploaded (by EBernhardson):
Make UsageException explicitly not loggable

https://gerrit.wikimedia.org/r/210235

gerritbot added a project: Patch-For-Review.May 11 2015, 11:03 PM
EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.May 11 2015, 11:03 PM
• Manybubbles moved this task from Search to On Sprint Board on the Discovery-ARCHIVED board.May 12 2015, 2:46 PM
gerritbot added a comment.May 12 2015, 5:10 PM

Change 210235 abandoned by EBernhardson:
Make UsageException explicitly not loggable

https://gerrit.wikimedia.org/r/210235

gerritbot added a comment.May 12 2015, 6:47 PM

Change 210402 had a related patch set uploaded (by EBernhardson):
Dont throw UsageException in non-api code

https://gerrit.wikimedia.org/r/210402

gerritbot added a comment.May 13 2015, 3:10 PM

Change 210402 merged by jenkins-bot:
Don't leak UsageException in non-api code paths

https://gerrit.wikimedia.org/r/210402

Diffusion mentioned this in rMEXT497fa6a19311: Updated mediawiki/extensions Project: mediawiki/extensions/CirrusSearch….May 13 2015, 3:10 PM
EBernhardson mentioned this in rECIR71be28390218: Don't leak UsageException in non-api code paths.May 13 2015, 3:10 PM
EBernhardson closed this task as Resolved.May 13 2015, 3:58 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.
• Deskana moved this task from Needs Reporting to Resolved on the Discovery-Search (Current work) board.Sep 9 2015, 2:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL