Page MenuHomePhabricator

CirrusSearch: Stop logging an error when I user sends a prefix query that is too long
Closed, ResolvedPublic

Description

They look like:
UsageException from line 1517 of /srv/mediawiki/php-1.26wmf4/extensions/CirrusSearch/includes/Searcher.php: Prefix search request was longer than the maximum allowed length. (1210 > 255)

Its nice that the user gets the error but we don't want to log the exception because its noisy.

Event Timeline

Manybubbles raised the priority of this task from to Normal.
Manybubbles updated the task description. (Show Details)
Manybubbles moved this task to Search on the Discovery board.
Manybubbles added a subscriber: Manybubbles.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2015, 9:27 PM
EBernhardson set Security to None.

These look to be because we are throwing an API specific exception (UsageException) from a special page.

Change 210235 had a related patch set uploaded (by EBernhardson):
Make UsageException explicitly not loggable

https://gerrit.wikimedia.org/r/210235

Change 210235 abandoned by EBernhardson:
Make UsageException explicitly not loggable

https://gerrit.wikimedia.org/r/210235

Change 210402 had a related patch set uploaded (by EBernhardson):
Dont throw UsageException in non-api code

https://gerrit.wikimedia.org/r/210402

Change 210402 merged by jenkins-bot:
Don't leak UsageException in non-api code paths

https://gerrit.wikimedia.org/r/210402

EBernhardson closed this task as Resolved.May 13 2015, 3:58 PM
EBernhardson moved this task from Needs review to Done on the Discovery-Search (Current work) board.