Puppet function: ipresolve: throw an error if lookup fails, refactor into wmflib
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gage
	May 20 2015, 9:08 PM

Description

We have a custom Puppet function called ipresolve: modules/strongswan/lib/puppet/parser/functions/ipresolve.rb

When an IP lookup fails, there is no output and also no error produced. In discussion in IRC, we agreed that it would be better to produce an error.

Because this function is stored inside the strongswan module, Yuvi didn't notice it and talked about writing a "resolve" function in wmflib. We agreed that ipresolve should be refactored into wmflib.

Subject	Repo	Branch	Lines +/-
wmflib: Make ipresolve throw an error if it can't resolve	operations/puppet	production	+4 -1
wmflib: Add nameserver parameter to ipresolve function	operations/puppet	production	+13 -7
wmflib: Move ipresolve function into wmflib	operations/puppet	production	+0 -0

Mentioned In: rOPUPcc11d15d566b: wmflib: Make ipresolve throw an error if it can't resolve
rOPUP9721d85364aa: wmflib: Add nameserver parameter to ipresolve function
rOPUPa5c1f98977d8: wmflib: Move ipresolve function into wmflib

• Gage raised the priority of this task from to Needs Triage.

• Gage updated the task description. (Show Details)

• Gage triaged this task as Medium priority.May 20 2015, 9:13 PM

• Gage set Security to None.

Change 212464 had a related patch set uploaded (by Yuvipanda):
wmflib: Move ipresolve function into wmflib

Change 212784 had a related patch set uploaded (by Yuvipanda):
wmflib: Add nameserver parameter to ipresolve function

Change 212464 merged by Yuvipanda:
wmflib: Move ipresolve function into wmflib

Change 212784 merged by Yuvipanda:
wmflib: Add nameserver parameter to ipresolve function

Change 215682 had a related patch set uploaded (by Yuvipanda):
wmflib: Make ipresolve throw an error if it can't resolve

Change 215682 merged by Yuvipanda:
wmflib: Make ipresolve throw an error if it can't resolve

@yuvipanda looks like you resolved it?

Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 5 2015, 6:31 AM

Think so!