How do we want to compare the current search performance to the new one? This task is to make sure we have the proper user journeys defined, implementing them in the [[ https://wikitech.wikimedia.org/wiki/Performance/User_Journey | Performance test repo ]], and setting up a dashboard.
This task does not cover any behavioral regression tests such as "the new UI is confusing."
== User journeys
=== Legacy Vector:
For anon cached and uncached, and logged-in uncached scenarios:
1. Visit the Barack Obama page.
1. Tap search.
1. Type "b".
1. Wait for a response.
1. Type "ananb" one character at a time.
1. Wait for a response.
1. Type "<backspace>a" one character at a time.
1. Wait for a response.
1. Tap the first result.
1. Wait for the page to load.
=== Latest Vector:
For anon cached and uncached, and logged-in uncached scenarios:
1. Visit the Barack Obama page.
1. Tap search.
1. //Wait for the form to load.//
1. Type "b".
1. Wait for a response.
1. Type "ananb" one character at a time.
1. Wait for a response.
1. Type "<backspace>a" one character at a time.
1. Wait for a response.
1. Tap the first result.
1. Wait for the page to load.
=== Questions
- Confirm with @ovasileva and @alexhollender that these journeys make sense.
- Is the Barack Obama page a good test for the tests wikis? The Performance team has also used the Sweden and Facebook pages. Is there a universal page that works on the test wikis (French Wikipedia and Wiktionary, Hebrew Wikipedia, Portuguese Wikiversity, Basque Wikipedia, and Persian Wikipedia)? Answer: there is no universal page. The Obama page is usually a good example of a large page. See T251544#6103760.
- Do we want to also test Special:BlankPage? Answer: no, but we may want to test an empty page in the user namespace. See T251544#6103760.
- Are parameters possible or do these break caching (see T215088#4993170)? E.g., `safemode=1`, `useskin=vector&useskinversion=2`, and `banner=null`. If not, how do we set the skin version and enable features?
- Do we need to test loading the largest dependencies (e.g., Vue) without using them (see T250336#6075053)?
== Dashboards
For Legacy and Latest modes, mimic at least the metrics described in [[ https://grafana.wikimedia.org/d/7zvDe0JZk/user-journey-drilldown?orgId=1 | the reference dashboard ]]:
- TTFB
- FirstVisualChange
- Heading
- LargestImage
- LastVisualChange
- SpeedIndex
- PerceptualSpeedIndex
- Fully Loaded
- ...
Both reports should be comparable on the same dashboard.
== Acceptance criteria
- [] Legacy and latest reports are comparable on the test wikis.
- [] [[ https://www.mediawiki.org/wiki/Reading/Web/Chores | Chores ]] are updated to include the new dashboards
- [] The wiki (either a link off of the [[ https://www.mediawiki.org/wiki/Vue.js | Vue.js page ]] or one of the Performance pages) is updated with recommendations for future Vue.js projects
- [] Performance team signs off on tests and dashboards
== QA steps
Measurement definitions:
**mwVector{Legacy/Vue}SearchLoadStartToLoadEnd**: Intended to measure the time it takes to load and execute the search module. Note, I've noticed this measurement can be the most skewed of the three measurements because [[https://github.com/wikimedia/mediawiki/blob/a08c95d61e5164b2b93f264a1604ebf3a2f4f8ed/resources/src/mediawiki.page.ready/ready.js#L184 | the load end time was implemented using the "mw.loader.using" callback ]] which places that code in a queue that can be influenced by other modules that are loading (e.g. ULS module). Although not desirable, this problem affects both Vue and legacy search.
**mwVector{Legacy/Vue}SearchLoadStartToFirstRender**: Intended to measure the time it takes from the start of lazy loading the search module to when the search results are visible to the user.
**mwVector{Legacy/Vue}SearchQueryToRender**: Intended to measure the time it takes from the start of the ajax request to fetch search results to when the search results are visible to the user.
Because of its technical depth, QA here is probably best done by a dev/someone familiar with the performance timeline. Here is how I'd suggest QAing it:
1) Clear localstorage/all cache and visit https://fr.wikipedia.org/wiki/Barack_Obama?useskinversion=1 with Chrome
2) Go to the performance tab and hit the record button
3) Focus the search input and type the letter "a" in the input
4) Wait for the search results to be shown
5) Stop profiling
6) Using the "Network", "Timings", and "Main" sections in the performance timeline, ensure the bars in the "Timings" section make sense according to the measurement definitions above. I've attached a screenshot of a timeline I did for Vue search which is annotated and might be useful as a reference
{F34148322}