Change Details

Minerva `$skinOptions` array is a part of SkinMinerva class. The problem is that `SkinOptions` are used in many places (main menu/page actions menu building, hooks, MinervaTemplate) and is going to be used in many more places (User menu, overflow menu). This is a crucial part of MinervaNeue system and it should be extracted to a separate service and properly hardened. ###Acceptance criteria: [x] SkinOptions are available as service. `SkinMinerva` has to know nothing about SkinOptions implementation [] SkinOptions constants do not have `OPTION_` or `OPTIONS_` prefix. [x] PHPUnit code coverage has to be >95% [] allow only known options to be set [] getting an unknown option should result in an exception

Minerva `$skinOptions` array is a part of SkinMinerva class. The problem is that `SkinOptions` are used in many places (main menu/page actions menu building, hooks, MinervaTemplate) and is going to be used in many more places (User menu, overflow menu). This is a crucial part of MinervaNeue system and it should be extracted to a separate service and properly hardened. ###Acceptance criteria: [x] SkinOptions are available as service. `SkinMinerva` has to know nothing about SkinOptions implementation [x] PHPUnit code coverage has to be >95% [] SkinOptions constants do not have `OPTION_` or `OPTIONS_` prefix. [] allow only known options to be set [] getting an unknown option should result in an exception ###Developer notes During code review of {258e635ae51002f28d2899e5522e03c5934b49eb} we noticed many places where code can be improved a bit. That's why we added couple more AC (like "allow only known options" to be set, or "getting an unknown option should result in an exception"). The requested improvements are so small they do not require a new task, we should re-use this task and improve/harden the `SkinOptions` clas.

Minerva `$skinOptions` array is a part of SkinMinerva class. The problem is that `SkinOptions` are used in many places (main menu/page actions menu building, hooks, MinervaTemplate) and is going to be used in many more places (User menu, overflow menu). This is a crucial part of MinervaNeue system and it should be extracted to a separate service and properly hardened. ###Acceptance criteria: [x] SkinOptions are available as service. `SkinMinerva` has to know nothing about SkinOptions implementation [] SkinOptions constants do not have `OPTION_` or `OPTIONS_` prefix.x] PHPUnit code coverage has to be >95% [x] PHPUnit code coverage has to be >95%] SkinOptions constants do not have `OPTION_` or `OPTIONS_` prefix. [] allow only known options to be set [] getting an unknown option should result in an exception ###Developer notes During code review of {258e635ae51002f28d2899e5522e03c5934b49eb} we noticed many places where code can be improved a bit. That's why we added couple more AC (like "allow only known options" to be set, or "getting an unknown option should result in an exception"). The requested improvements are so small they do not require a new task, we should re-use this task and improve/harden the `SkinOptions` clas.