Change Details

Two issues: * The standard logout goes to Special:Userlogout, it used to work ,but was broken due to a refactor of HTML * The sticky header logout never worked. # new proposal Currently the way this works is code runnning in mediawiki core runs on page load and adds a click handler to anything which matches the selector. The selector can be configured on a skin basis (and is done that way inside Vector). It's proposed that we do one of two things: 1) Switch the click handler to run on document - the performance team has stated they prefer we don't do this 2) Switch to an event based approach `mw.hook('mw.logout').add` and add additionalevent bindings inside Vector 2022. # More background > When I try to log-out via sticky header, I always have to click twice: once on the log-out button, then on the blue button from [[https://www.mediawiki.org/wiki/Special:UserLogout|Special:UserLogout]]. This is annoying. ([[https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements#Logging-out_via_sticky_header|source]]) On the other hand though, to me, this looks like a possible solution to the problem of too many misclicks. Is this intentional? If yes, can we keep this as a two-step process but without redirecting the user to different wiki page?

Two issues: * The standard logout goes to Special:Userlogout, it used to work ,but was broken due to a refactor of HTML * The sticky header logout never worked. # problems * The sticky header is added via JavaScript after page load * Since Vector 2022 doesn't wire up the logout code itself, any HTML changes can break the integration. # new proposal Currently the way this works is code runnning in mediawiki core runs on page load and adds a click handler to anything which matches the selector. The selector can be configured on a skin basis (and is done that way inside Vector). It's proposed that we do one of two things: 1) Switch the click handler to run on document - the performance team has stated they prefer we don't do this 2) Switch to an event based approach `mw.hook('mw.logout').add` and add additionalevent bindings inside Vector 2022. # More background > When I try to log-out via sticky header, I always have to click twice: once on the log-out button, then on the blue button from [[https://www.mediawiki.org/wiki/Special:UserLogout|Special:UserLogout]]. This is annoying. ([[https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements#Logging-out_via_sticky_header|source]]) On the other hand though, to me, this looks like a possible solution to the problem of too many misclicks. Is this intentional? If yes, can we keep this as a two-step process but without redirecting the user to different wiki page?

Two issues: * The standard logout goes to Special:Userlogout, it used to work ,but was broken due to a refactor of HTML * The sticky header logout never worked. # problems * The sticky header is added via JavaScript after page load * Since Vector 2022 doesn't wire up the logout code itself, any HTML changes can break the integration. # new proposal Currently the way this works is code runnning in mediawiki core runs on page load and adds a click handler to anything which matches the selector. The selector can be configured on a skin basis (and is done that way inside Vector). It's proposed that we do one of two things: 1) Switch the click handler to run on document - the performance team has stated they prefer we don't do this 2) Switch to an event based approach `mw.hook('mw.logout').add` and add additionalevent bindings inside Vector 2022. # More background > When I try to log-out via sticky header, I always have to click twice: once on the log-out button, then on the blue button from [[https://www.mediawiki.org/wiki/Special:UserLogout|Special:UserLogout]]. This is annoying. ([[https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements#Logging-out_via_sticky_header|source]]) On the other hand though, to me, this looks like a possible solution to the problem of too many misclicks. Is this intentional? If yes, can we keep this as a two-step process but without redirecting the user to different wiki page?