HomePhabricator

Transactions T91595 Change Details

Change Details

Old
New
Diff

This could be deliberate, but it looks silly: `ve.init.mw.ViewPageTarget.prototype.setupToolbar` gets called twice during VE initialization. The `if ( !wasSetup )` guard ensures that the CSS transition is only applied once, but it does not prevent the a duplicate `toolbarSetupDeferred` done handler from being registered.

This could be deliberate, but it looks silly: `ve.init.mw.ViewPageTarget.prototype.setupToolbar` gets called twice during VE initialization. The `if ( !wasSetup )` guard ensures that the CSS transition is only applied once, but it does not prevent the a duplicate `toolbarSetupDeferred` done handler from being registered.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL