Change Details

//Once again, Collection extension hits us :) // --- There are several things to do in Collection as part of this work. Collection makes use of 2 VirtualRESTServiceClient classes, i.e. ElectronVirtualRestService and RestbaseVirtualRestService. Both are mounted using different module names (electron and restbase respectively). Electron is broken/disabled in production, should we fix it for third-parties? Should we just delete the VRS class completely? RESTBase is also an issue to deal with and we can move this to HTTP if its still worth it. As a result of the extension broken in so many places, there is a lot of dead code that can just be removed. NOTE: Special:RenderBook is not working and the code says it should redirect to Special:Book but it doesn't. Should we just delete the special page? Sub-tasks for tackling these issues one at a time will be created. == Acceptance Criteria == [x] Identify various portions of the extension that are broken and make a decision whether to delete the code or fix it. [ ] Delete code that mounts `restbase` module (RestbaseVirtualRestService) as this is broken. [ ] Delete completely the `electron` module (ElectronVirtualRestService). [ ] Delete the code around `Special:RenderBook` [ ] Ensure nothing around VirtualRestService is in this extension [ ] Confirm that Special:Book is still working correctly.

//Once again, Collection extension hits us :) // --- There are several things to do in Collection as part of this work. Collection makes use of 2 VirtualRESTServiceClient classes, i.e. ElectronVirtualRestService and RestbaseVirtualRestService. Both are mounted using different module names (electron and restbase respectively). Electron is broken/disabled in production, should we fix it for third-parties? Should we just delete the VRS class completely? RESTBase is also an issue to deal with and we can move this to HTTP if its still worth it. As a result of the extension broken in so many places, there is a lot of dead code that can just be removed. NOTE: Special:RenderBook is not working and the code says it should redirect to Special:Book but it doesn't. Should we just delete the special page? Sub-tasks for tackling these issues one at a time will be created. == Acceptance Criteria == [x] Identify various portions of the extension that are broken and make a decision whether to delete the code or fix it. [x] Delete code that mounts `restbase` module (RestbaseVirtualRestService) as this is broken. [x] Delete completely the `electron` module (ElectronVirtualRestService). [x] Delete the code around `Special:RenderBook` [x] Ensure nothing around VirtualRestService is in this extension [x] Confirm that Special:Book is still working correctly locally. [ ] Monitor sites that have Collection on production to ensure everything still runs as expected after the train.

//Once again, Collection extension hits us :) // --- There are several things to do in Collection as part of this work. Collection makes use of 2 VirtualRESTServiceClient classes, i.e. ElectronVirtualRestService and RestbaseVirtualRestService. Both are mounted using different module names (electron and restbase respectively). Electron is broken/disabled in production, should we fix it for third-parties? Should we just delete the VRS class completely? RESTBase is also an issue to deal with and we can move this to HTTP if its still worth it. As a result of the extension broken in so many places, there is a lot of dead code that can just be removed. NOTE: Special:RenderBook is not working and the code says it should redirect to Special:Book but it doesn't. Should we just delete the special page? Sub-tasks for tackling these issues one at a time will be created. == Acceptance Criteria == [x] Identify various portions of the extension that are broken and make a decision whether to delete the code or fix it. [ x] Delete code that mounts `restbase` module (RestbaseVirtualRestService) as this is broken. [ x] Delete completely the `electron` module (ElectronVirtualRestService). [ x] Delete the code around `Special:RenderBook` [ x] Ensure nothing around VirtualRestService is in this extension [ x] Confirm that Special:Book is still working correctly locally. [ ] Monitor sites that have Collection on production to ensure everything still runs as expected after the train.