Change Details

There is one browser test in the repo that did not test the right thing as we have found out recently https://phabricator.wikimedia.org/T291467. There seems to be some issue with the eslint/jshint configuration as this had to be disabled to make the test actually test something. Lets update the configuration and enable linting for the spec.

Currently, wikidata-query-gui uses the same eslint/jshint configuration for the main source code and the tests. This is annoying, because it means we can’t use arrow functions, async/await, etc. in the tests, even though those tests will only run on Node.js versions that have support for these features. It would be nice to split up the config, so that we still require “conservative” JavaScript for the main source code, but allow more modern code in the tests. It’s probably also a good idea to check why we’re combining eslint and jshint. This came up in the context of T291467.

There is one browser test in the repo that did not test the right thing as we have found out recently https://phabricator.wikimedia.org/T291467Currently, wikidata-query-gui uses the same eslint/jshint configuration for the main source code and the tests. This is annoying, because it means we can’t use arrow functions, async/await, etc. in the tests, even though those tests will only run on Node.js versions that have support for these features. It would be nice to split up the config, so that we still require “conservative” JavaScript for the main source code, but allow more modern code in the tests. There seems to be some issue with the eslint/jshint configuration as this had to be disabled to make the test actually test something. Lets update the configuration and enable linting for the specIt’s probably also a good idea to check why we’re combining eslint and jshint. This came up in the context of T291467.