Change Details

There are as much a **3 bug reports** that I've come across in the recent days that come down to one reason. The reason is the code for {T285956} (part of the solution for {T285285}) that introduced [[https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.diff.styles/diff.js;a14ae963de5c3979da181a079611e93d98cad3c6$14|this line of code]]: ``` document.getSelection().removeAllRanges(); ``` (@Daimona). It seems to be the immediate reason of the issues. The reports themselves were: 1. Dragging and dropping text selected in diffs doesn't work ([[https://ru.wikipedia.org/wiki/Википедия:Форум/Технический#Перетаскивание_мышкой_выделенного_в_диффах_текста|link]]). 2. On diff pages, one cannot use Shift+click to extend the selected text (by @stjn). 3. In #convenient-discussions one cannot choose an autocomplete item because the input loses the selection (I've fixed that in the script already) (by @MBH).

There are as much a **3 bug reports** that I've come across in the recent days that come down to one reason. The reason is the code for {T285956} (part of the solution for {T285285}) that introduced [[https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.diff.styles/diff.js;a14ae963de5c3979da181a079611e93d98cad3c6$14|this line of code]]: ``` document.getSelection().removeAllRanges(); ``` (@Daimona). It seems to be the immediate reason of the issues. The reports themselves were: 1. Dragging and dropping text selected in diffs doesn't work ([[https://ru.wikipedia.org/wiki/Википедия:Форум/Технический#Перетаскивание_мышкой_выделенного_в_диффах_текста|link]]). 2. On diff pages, one cannot use Shift+click to extend the selected text (by @stjn). 3. In #convenient-discussions one cannot choose an autocomplete item because the text input loses the selection (I've fixed that in the script already) (by @MBH).

There are as much a **3 bug reports** that I've come across in the recent days that come down to one reason. The reason is the code for {T285956} (part of the solution for {T285285}) that introduced [[https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.diff.styles/diff.js;a14ae963de5c3979da181a079611e93d98cad3c6$14|this line of code]]: ``` document.getSelection().removeAllRanges(); ``` (@Daimona). It seems to be the immediate reason of the issues. The reports themselves were: 1. Dragging and dropping text selected in diffs doesn't work ([[https://ru.wikipedia.org/wiki/Википедия:Форум/Технический#Перетаскивание_мышкой_выделенного_в_диффах_текста|link]]). 2. On diff pages, one cannot use Shift+click to extend the selected text (by @stjn). 3. In #convenient-discussions one cannot choose an autocomplete item because the text input loses the selection (I've fixed that in the script already) (by @MBH).