Change Details

== Background Followup to https://phabricator.wikimedia.org/T360917 and https://phabricator.wikimedia.org/T362939 Based off feedback we want to only use margins for spacing, and remove the hacky padding solution. == User story - As a Wikipedia reader, I want consistent spacing and information hierarchy in articles where headers are closer to the text that they are heading and there is enough spacing between paragraphs to differentiate one from another at a glance. == Design - Breaks between paragraphs should measure 1em of computed space, which scales depending on the size of the text selected in the Appearance menu. - Lists, images, tables, block quotes, and other "inline" elements should have 0.5 em of space between paragraphs == Acceptance criteria - Paragraphs should have margin-top 0.5em and margin-bottom 1em - inline elements next to paragraphs should have 0.5 spacing == QA - Run pixel with this patch to review changes - review different types of user generated content and edge cases with the patch demo here: https://patchdemo.wmflabs.org/wikis/228f3d1cc6/wiki/Main_Page == Communication criteria - does this need an announcement or discussion? - no == Rollback plan - make sure the change is made in a single patch, so if a revert is needed we can revert that single patch.

== Background Followup to https://phabricator.wikimedia.org/T360917 and https://phabricator.wikimedia.org/T362939 Based off feedback we want to only use margins for spacing, and remove the hacky padding solution. == User story - As a Wikipedia reader, I want consistent spacing and information hierarchy in articles where headers are closer to the text that they are heading and there is enough spacing between paragraphs to differentiate one from another at a glance. == Design - Breaks between paragraphs should measure 1em of computed space, which scales depending on the size of the text selected in the Appearance menu. - Lists, images, tables, block quotes, and other "inline" elements should have 0.5 em of space between paragraphs == Requirement Ensure that paragraph spacing in the Vector 2022 skin is consistent and follows the design specifications. Paragraphs should have a margin-top of 0.5em and a margin-bottom of 1em. Inline elements next to paragraphs should have 0.5em of spacing. == BDD ```gherkin Feature: Consistent Paragraph Spacing in Vector 2022 Scenario: Ensure correct paragraph spacing and inline element spacing Given a user is viewing content in the Vector 2022 skin When the user views paragraphs and inline elements Then the paragraphs should have a margin-top of 0.5em and a margin-bottom of 1em And inline elements next to paragraphs should have 0.5em of spacing ``` == Test Steps __Test Case 1: Verify Paragraph and Inline Element Spacing in Vector 2022__ 1. Open the Vector 2022 skin. 2. Navigate to [this patch demo page](https://patchdemo.wmflabs.org/wikis/228f3d1cc6/wiki/Main_Page). 3. Verify the paragraph spacing. 4. **AC1:** Confirm that paragraphs have a margin-top of 0.5em and a margin-bottom of 1em. 5. Verify the inline element spacing next to paragraphs. 6. **AC2:** Confirm that inline elements next to paragraphs have 0.5em of spacing. == Acceptance criteria - Paragraphs should have margin-top 0.5em and margin-bottom 1em - inline elements next to paragraphs should have 0.5 spacing == QA - Run pixel with this patch to review changes - review different types of user generated content and edge cases with the patch demo here: https://patchdemo.wmflabs.org/wikis/228f3d1cc6/wiki/Main_Page == Communication criteria - does this need an announcement or discussion? - no == Rollback plan - make sure the change is made in a single patch, so if a revert is needed we can revert that single patch.

== Background Followup to https://phabricator.wikimedia.org/T360917 and https://phabricator.wikimedia.org/T362939 Based off feedback we want to only use margins for spacing, and remove the hacky padding solution. == User story - As a Wikipedia reader, I want consistent spacing and information hierarchy in articles where headers are closer to the text that they are heading and there is enough spacing between paragraphs to differentiate one from another at a glance. == Design - Breaks between paragraphs should measure 1em of computed space, which scales depending on the size of the text selected in the Appearance menu. - Lists, images, tables, block quotes, and other "inline" elements should have 0.5 em of space between paragraphs == Requirement Ensure that paragraph spacing in the Vector 2022 skin is consistent and follows the design specifications. Paragraphs should have a margin-top of 0.5em and a margin-bottom of 1em. Inline elements next to paragraphs should have 0.5em of spacing. == BDD ```gherkin Feature: Consistent Paragraph Spacing in Vector 2022 Scenario: Ensure correct paragraph spacing and inline element spacing Given a user is viewing content in the Vector 2022 skin When the user views paragraphs and inline elements Then the paragraphs should have a margin-top of 0.5em and a margin-bottom of 1em And inline elements next to paragraphs should have 0.5em of spacing ``` == Test Steps __Test Case 1: Verify Paragraph and Inline Element Spacing in Vector 2022__ 1. Open the Vector 2022 skin. 2. Navigate to [this patch demo page](https://patchdemo.wmflabs.org/wikis/228f3d1cc6/wiki/Main_Page). 3. Verify the paragraph spacing. 4. **AC1:** Confirm that paragraphs have a margin-top of 0.5em and a margin-bottom of 1em. 5. Verify the inline element spacing next to paragraphs. 6. **AC2:** Confirm that inline elements next to paragraphs have 0.5em of spacing. == Acceptance criteria - Paragraphs should have margin-top 0.5em and margin-bottom 1em - inline elements next to paragraphs should have 0.5 spacing == QA - Run pixel with this patch to review changes - review different types of user generated content and edge cases with the patch demo here: https://patchdemo.wmflabs.org/wikis/228f3d1cc6/wiki/Main_Page == Communication criteria - does this need an announcement or discussion? - no == Rollback plan - make sure the change is made in a single patch, so if a revert is needed we can revert that single patch.