Change Details

For the MVP of IP Masking, the Growth team wants temporary users to behave the same way as anonymous users (T327420#8998167), with the exception of notifications (see T330509). According to the [IP Masking guide](https://www.mediawiki.org/wiki/Help:Temporary_accounts/How_it_works), this means we need to do the following changes in the codebase: | **Current code** | **Change to** | | `$user->isRegistered()` | `$user->isNamed()` | | `$user->isAnon()` | `!$user->isNamed()` | Those changes should be done in a batch of patches that gets merged relatively soon to avoid excessive merge conflicts. After that is done, the features should be checked on `dewiki beta` and/or locally (with IP Masking enabled, see [betawiki config](https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings-labs.php#L447-L450)) for issues that might be IP Masking related, such as: * Temporary users have access to a feature or a component that should be only available to registered users, or * Registered users stopped having access to a feature that should be available to them Changes made in this task should have no impact on the production wikis, unless and until IP Masking gets enabled there. === Components checklist (Loosely based on the list from {T326877}; PageTriage not included because of T339252, Nuke not included because it has no calls to the relevant functions, Notifications not included because it should actually be available to temp users, NewUserActions/NewUserNotif removed because not Wikimedia-deployed and not responsible as per {MW.org docs](https://www.mediawiki.org/wiki/Developers/Maintainers)) ==== Extensions [X] GrowthExperiments (done in [938830](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/938830/)) [] Thanks [] StructuredDiscussions (aka Flow) [X] Wikilove (done in [915630](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLove/+/915630)) [X] MW-extensions-GuidedTour (no changes needed) [X] MW-extensions-NewUserMessage (done in [943552](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NewUserMessage/+/943552)) [X] MW-Extensions-ORES (no changes needed) ==== Core components [] Recent changes [] Watchlist (done in [944885](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/944885))

For the MVP of IP Masking, the Growth team wants temporary users to behave the same way as anonymous users (T327420#8998167), with the exception of notifications (see T330509). According to the [IP Masking guide](https://www.mediawiki.org/wiki/Help:Temporary_accounts/How_it_works), this means we need to do the following changes in the codebase: | **Current code** | **Change to** | | `$user->isRegistered()` | `$user->isNamed()` | | `$user->isAnon()` | `!$user->isNamed()` | Those changes should be done in a batch of patches that gets merged relatively soon to avoid excessive merge conflicts. After that is done, the features should be checked on `dewiki beta` and/or locally (with IP Masking enabled, see [betawiki config](https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings-labs.php#L447-L450)) for issues that might be IP Masking related, such as: * Temporary users have access to a feature or a component that should be only available to registered users, or * Registered users stopped having access to a feature that should be available to them Changes made in this task should have no impact on the production wikis, unless and until IP Masking gets enabled there. === Components checklist (Loosely based on the list from {T326877}; PageTriage not included because of T339252, Nuke not included because it has no calls to the relevant functions, Notifications not included because it should actually be available to temp users, NewUserActions/NewUserNotif removed because not Wikimedia-deployed and not responsible as per {MW.org docs](https://www.mediawiki.org/wiki/Developers/Maintainers)) ==== Extensions [X] GrowthExperiments (done in [938830](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/938830/)) [] Thanks [] StructuredDiscussions (aka Flow) [X] Wikilove (done in [915630](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLove/+/915630)) [X] MW-extensions-GuidedTour (no changes needed) [X] MW-extensions-NewUserMessage (done in [943552](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NewUserMessage/+/943552)) [X] MW-Extensions-ORES (no changes needed) ==== Core components [] Recent changes [X] Watchlist (done in [948208](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/948208))

For the MVP of IP Masking, the Growth team wants temporary users to behave the same way as anonymous users (T327420#8998167), with the exception of notifications (see T330509). According to the [IP Masking guide](https://www.mediawiki.org/wiki/Help:Temporary_accounts/How_it_works), this means we need to do the following changes in the codebase: | **Current code** | **Change to** | | `$user->isRegistered()` | `$user->isNamed()` | | `$user->isAnon()` | `!$user->isNamed()` | Those changes should be done in a batch of patches that gets merged relatively soon to avoid excessive merge conflicts. After that is done, the features should be checked on `dewiki beta` and/or locally (with IP Masking enabled, see [betawiki config](https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings-labs.php#L447-L450)) for issues that might be IP Masking related, such as: * Temporary users have access to a feature or a component that should be only available to registered users, or * Registered users stopped having access to a feature that should be available to them Changes made in this task should have no impact on the production wikis, unless and until IP Masking gets enabled there. === Components checklist (Loosely based on the list from {T326877}; PageTriage not included because of T339252, Nuke not included because it has no calls to the relevant functions, Notifications not included because it should actually be available to temp users, NewUserActions/NewUserNotif removed because not Wikimedia-deployed and not responsible as per {MW.org docs](https://www.mediawiki.org/wiki/Developers/Maintainers)) ==== Extensions [X] GrowthExperiments (done in [938830](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/938830/)) [] Thanks [] StructuredDiscussions (aka Flow) [X] Wikilove (done in [915630](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLove/+/915630)) [X] MW-extensions-GuidedTour (no changes needed) [X] MW-extensions-NewUserMessage (done in [943552](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NewUserMessage/+/943552)) [X] MW-Extensions-ORES (no changes needed) ==== Core components [] Recent changes [X] Watchlist (done in [9448858208](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/9448858208))