Change Details

I was working with @matmarex on https://phabricator.wikimedia.org/T346944 and one unexpected side effect of improving our API in Minerva is that the two edit tab behaviour of VisualEditor is now carried over to the mobile site. This means for wikis where $wgVisualEditorUseSingleEditTab is false, two edit icons will appear on the mobile site like in the screenshot. Is this an improvement or something we should update VisualEditor to restrict the hook code for wgVisualEditorUseSingleEditTab to desktop?

I was working with @matmarex on https://phabricator.wikimedia.org/T346944 and one unexpected side effect of improving our API in Minerva is that the two edit tab behaviour of VisualEditor is now carried over to the mobile site. This means for wikis where $wgVisualEditorUseSingleEditTab is false, two edit icons will appear on the mobile site like in the screenshot. Is this an improvement or something we should update VisualEditor to restrict the hook code for wgVisualEditorUseSingleEditTab to desktop? Before: {F38033223} After: {F38033155}

I was working with @matmarex on https://phabricator.wikimedia.org/T346944 and one unexpected side effect of improving our API in Minerva is that the two edit tab behaviour of VisualEditor is now carried over to the mobile site. This means for wikis where $wgVisualEditorUseSingleEditTab is false, two edit icons will appear on the mobile site like in the screenshot. Is this an improvement or something we should update VisualEditor to restrict the hook code for wgVisualEditorUseSingleEditTab to desktop? Before: {F38033223} After: {F38033155}