Change Details

In course of getting rid of WVUI as per T310243 in our [[ https://codesearch.wmcloud.org/things/?q=wvui&i=nope&files=&excludeFiles=&repos= | Wikimedia-deployed codebase ]] one of the WVUI remainders is the old TypeaheadSearch CSS selector. Question is, should we update the extension? Is it still in use?

The SearchSatisfaction previously logged "WVUI" inside the extraParams field if the Vector search was built via WVUI. Presumably this was to distinguish it from the default jQuery search box and compare results for both. This behaviour was broken with the migration from WVUI to Codex. Now, the extraParams field has no distinction for Codex. This is presumably okay, as it should be impossible to get anything but the Codex search input inside the Vector 2022 skin and for Vector legacy it will always be the non-Codex search. We should therefore remove this code.

In course of getting rid of WVUI as per T310243 in our [[ https://codesearch.wmcloud.org/things/?q=wvui&i=nope&files=&excludeFiles=&repos= | Wikimedia-deployed codebase ]] one of the WVUI remainders is the old TypeaheadSearch CSS selectorThe SearchSatisfaction previously logged "WVUI" inside the extraParams field if the Vector search was built via WVUI. Presumably this was to distinguish it from the default jQuery search box and compare results for both. QuesThis behaviour was broken with the migration isfrom WVUI to Codex. Now, should we update the extension?the extraParams field has no distinction for Codex. This is presumably okay, Is it still in use?as it should be impossible to get anything but the Codex search input inside the Vector 2022 skin and for Vector legacy it will always be the non-Codex search. We should therefore remove this code.