Change Details

From https://github.com/netbox-community/pynetbox#threading pynetbox supports threading for .all() and .filter() I gave it a try on netbox-dev with `generate_dns_snippets.py` as it contains a lot of .all() and .filter() and the performance improvement is there: **2m9s vs. 1m26s** See output on {P30535} Looking at the release notes on https://github.com/netbox-community/pynetbox/releases?q=thread&expanded=true Even though it would works on 5.3.1 (previous target with {T310745}) 6.1.1 fixes an [[ https://github.com/netbox-community/pynetbox/pull/364 | issue ]] that could be problematic. So next steps: [] {T310745} >= 6.1.1 [x] Enable threading on `generate_dns_snippets.py` [] Check the server side impact (rollback and re-asses if needed) [] Roll out to all the scripts and cookbooks Note that it's a parallel effort to {T310577} but have the advantage of being a potential easy win (big impact, low cost).

From https://github.com/netbox-community/pynetbox#threading pynetbox supports threading for .all() and .filter() I gave it a try on netbox-dev with `generate_dns_snippets.py` as it contains a lot of .all() and .filter() and the performance improvement is there: **2m9s vs. 1m26s** See output on {P30535} Looking at the release notes on https://github.com/netbox-community/pynetbox/releases?q=thread&expanded=true Even though it would works on 5.3.1 (previous target with {T310745}) 6.1.1 fixes an [[ https://github.com/netbox-community/pynetbox/pull/364 | issue ]] that could be problematic. So next steps: [x] {T310745} >= 6.1.1 [x] Enable threading on `generate_dns_snippets.py` [x] Check the server side impact (rollback and re-asses if needed) [x] Roll out to all the scripts and cookbooks [x] Spicerack - https://gerrit.wikimedia.org/r/c/operations/software/spicerack/+/822339 [x] Homer - https://gerrit.wikimedia.org/r/c/operations/software/homer/+/828031 [x] DNS/Ganeti/mgmt scripts - https://gerrit.wikimedia.org/r/c/operations/software/netbox-extras/+/828035 Note that it's a parallel effort to {T310577} but have the advantage of being a potential easy win (big impact, low cost).

From https://github.com/netbox-community/pynetbox#threading pynetbox supports threading for .all() and .filter() I gave it a try on netbox-dev with `generate_dns_snippets.py` as it contains a lot of .all() and .filter() and the performance improvement is there: **2m9s vs. 1m26s** See output on {P30535} Looking at the release notes on https://github.com/netbox-community/pynetbox/releases?q=thread&expanded=true Even though it would works on 5.3.1 (previous target with {T310745}) 6.1.1 fixes an [[ https://github.com/netbox-community/pynetbox/pull/364 | issue ]] that could be problematic. So next steps: [x] {T310745} >= 6.1.1 [x] Enable threading on `generate_dns_snippets.py` [x] Check the server side impact (rollback and re-asses if needed) [x] Roll out to all the scripts and cookbooks [x] Spicerack - https://gerrit.wikimedia.org/r/c/operations/software/spicerack/+/822339 [x] Homer - https://gerrit.wikimedia.org/r/c/operations/software/homer/+/828031 [x] DNS/Ganeti/mgmt scripts - https://gerrit.wikimedia.org/r/c/operations/software/netbox-extras/+/828035 Note that it's a parallel effort to {T310577} but have the advantage of being a potential easy win (big impact, low cost).