Change Details

PageTriage doesn't have any [browser end-to-end tests](https://www.mediawiki.org/wiki/Selenium). I think it would be quite useful to add some for 1) interactions with buttons on the Special:NewPagesFeed page and 2) use of the toolbar when viewing articles. There's some set up work needed in order to create or import content so that the feed and toolbar will have something to display. (Selenium tests in GrowthExperiments have some examples of importing content that could be a useful reference.) Or instead of setting up content, we could set up a static service that would return API results needed for the tests. Anyway, having something would be better than nothing, and make +2'ing patches a bit easier for developers who don't have PageTriage set up locally in their development environments.

Automated Selenium tests would be helpful for ensuring that critical code paths in the PageTriage extension are not accidentally broken. * Special:NewPagesFeed [ ] should display unreviewed new article [ ] should display recently reviewed article [ ] should display recently autopatrolled article [ ] should infinite scroll if queue is large enough [ ] should display submitted drafts [ ] should display declined drafts [ ] snippet should work correctly [ ] clicking "Review" should go to article page * Page Curation toolbar [ ] should be minimizable, closeable, and openable (first button) [ ] should open information sub-menu (second button) [ ] should open wikilove sub-menu, and send wikilove (third button) (extra setup: installation of WikiLove extension) [ ] should open mark as reviewed sub-menu, mark as reviewed, and mark as unreviewed (fourth button) [ ] should send a message to the creator (fourth button) [ ] should open maintenance tag sub-menu, and apply {{More footnotes}} (fifth button) (extra setup: MediaWiki:PageTriageExternalTagsOptions.js) [ ] should open deletion tag sub-menu, and apply a CSD G11 (Unambiguous advertising or promotion) tag (sixth button) (extra setup: [ ] should open deletion tag sub-menu, and apply a prod tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js) [ ] should open deletion tag sub-menu, and apply an AFD tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js) [ ] should proceed to next unreviewed article in queue (seventh button) * NOINDEX tests [ ] test various combinations of $wgPageTriageNoIndexUnreviewedNewArticles, $wikitextHasNoIndexMagicWord, $wgPageTriageMaxAge, $wgPageTriageMaxNoIndexAge, articles before the age, articles after the age, reviewed articles, and unreviewed articles

PageTriage doesn't have any [browser end-to-end tests](https://www.mediawiki.org/wiki/Selenium). I think it would be quite useful to add some for 1) interactions with buttons on the Special:NewPagesFeed page and 2) use of the toolbar when viewing articlesAutomated Selenium tests would be helpful for ensuring that critical code paths in the PageTriage extension are not accidentally broken. There's some set up work needed in order to create or import content so that the feed and toolbar will have something to display.* Special:NewPagesFeed [ ] should display unreviewed new article [ ] should display recently reviewed article [ ] should display recently autopatrolled article [ ] should infinite scroll if queue is large enough [ ] should display submitted drafts [ ] should display declined drafts [ ] snippet should work correctly [ ] clicking "Review" should go to article page * Page Curation toolbar [ ] should be minimizable, closeable, and openable (first button) [ ] should open information sub-menu (second button) [ ] should open wikilove sub-menu, and send wikilove (third button) (extra setup: installation of WikiLove extension) [ ] should open mark as reviewed sub-menu, mark as reviewed, and mark as unreviewed (fourth button) [ ] should send a message to the creator (fourth button) [ ] should open maintenance tag sub-menu, and apply {{More footnotes}} (fifth button) (extra setup: MediaWiki:PageTriageExternalTagsOptions.js) [ ] should open deletion tag sub-menu, and apply a CSD G11 (Unambiguous advertising or promotion) tag (sixth button) (extra setup: [ ] should open deletion tag sub-menu, and apply a prod tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js) [ ] should open deletion tag sub-menu, and apply an AFD tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js) [ ] should proceed to next unreviewed article in queue (seventh button) * NOINDEX tests [ ] test various combinations of $wgPageTriageNoIndexUnreviewedNewArticles, $wikitextHasNoIndexMagicWord, (Selenium tests in GrowthExperiments have some examples of importing content that could be a useful reference.) Or instead of setting up content$wgPageTriageMaxAge, $wgPageTriageMaxNoIndexAge, we could set up a static servicarticles before that would return API results needed foe age, articles after the tests. Anywayage, having something would be better than nothingreviewed articles, and make +2'ing patches a bit easier for developers who don't have PageTriage set up locally in their development environments.unreviewed articles