Change Details

The Popups extension has several logging and metrics options. Verify whether the interactions between page and reference previews are polluting metrics. [] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/pageviews.js | Virtual pageviews ]]: Make sure we aren't logging a virtual pageview for reference previews. [] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/eventLogging.js$132 | Eventlogging ]]: Reference previews are counted in Popups events, for example `action=dismiss`. Popups event logging is currently disabled everywhere, so there is no impact other than the technical and conceptual debt (e.g., is the type of preview recorded as an enum field?) to be cleaned up. [] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/statsv.js | Statsv ]]:

The Popups extension has several logging and metrics options. Verify whether the interactions between page and reference previews are polluting metrics. [x] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/pageviews.js | Virtual pageviews ]]: Make sure we aren't logging a virtual pageview for reference previews. **Outcome**: We don't send a virtual pageview for reference preview popups. [x] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/eventLogging.js$132 | Eventlogging ]] **Outcome**: Reference previews are counted in Popups events, for example `action=dismiss`. Popups event logging is currently disabled everywhere, so there is no impact other than the technical and conceptual debt (e.g., is the type of preview recorded as an enum field?) to be cleaned up. [] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/statsv.js | Statsv ]]: ...

The Popups extension has several logging and metrics options. Verify whether the interactions between page and reference previews are polluting metrics. [x] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/pageviews.js | Virtual pageviews ]]: Make sure we aren't logging a virtual pageview for reference previews. **Outcome**: We don't send a virtual pageview for reference preview popups. [x] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/eventLogging.js$132 | Eventlogging ]] **Outcome**: Reference previews are counted in Popups events, for example `action=dismiss`. Popups event logging is currently disabled everywhere, so there is no impact other than the technical and conceptual debt (e.g., is the type of preview recorded as an enum field?) to be cleaned up. [] [[ https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/reducers/statsv.js | Statsv ]]: ...