During verification of our open and close metrics, we discovered a systematic 17% of missing close events. Consulting the [[ https://www.mediawiki.org/wiki/VisualEditor/FeatureUse_data_dictionary | feature dictionary ]], we missed two event types. These correspond to workflows we hadn't considered in the first iteration of metrics:
* `dialog-insert`: This is the same as the "successful close" event, but sent when adding a new template rather than editing an existing invocation.
Recommendation: we add these to `dialog-close` when tallying successful close.
* `dialog-remove`: Supposedly this is sent when removing a template invocation, but I didn't find how to accomplish that using the dialog. TODO: Query events to see if this is ever sent.
Acceptance criteria:
[] Add these metrics to front-end collection.
[] Decide how to aggregate.
[] Add to the aggregations.
Follow-up work:
[] Update Grafana panels