Change Details

When introducing the "body" parameter source, we initially added body parameters to getParamSettings(). We later introduced getBodyParamSettings(), because callers generally want either real (body or query) params or body params, but not both. Also, body params are not inclued in the return value of getValidatedParams(), which was confusing. We should prohibit "body" parameters in the return value of getParamSettings(). This could be enforced by RestStructureTest. Before we can do that, we need to update extensions that are now returning bodyparams from getParaSettings. CheckUser, ReportIncident, and WikimediaCampaignEvents are already correctly using getBodyParamSettings. [] fix CampaignEvents [] fix ReadingLists [] fix GrowthExperiments [] fix FlaggedRevs [] make RestStructureTest fail when "body" parameters are returned from getParamSettings [] remove backwards compatibility code from the default implementation of getBodyParamSettings, so it simply returns an empty array.

When introducing the "body" parameter source, we initially added body parameters to getParamSettings(). We later introduced getBodyParamSettings(), because callers generally want either real (body or query) params or body params, but not both. Also, body params are not inclued in the return value of getValidatedParams(), which was confusing. We should prohibit "body" parameters in the return value of getParamSettings(). This could be enforced by RestStructureTest. Before we can do that, we need to update extensions that are now returning bodyparams from getParaSettings. CheckUser, ReportIncident, and WikimediaCampaignEvents are already correctly using getBodyParamSettings. [] fix CampaignEvents [] fix ReadingLists [x] fix GrowthExperiments [x] fix FlaggedRevs [] make RestStructureTest fail when "body" parameters are returned from getParamSettings [] remove backwards compatibility code from the default implementation of getBodyParamSettings, so it simply returns an empty array.

When introducing the "body" parameter source, we initially added body parameters to getParamSettings(). We later introduced getBodyParamSettings(), because callers generally want either real (body or query) params or body params, but not both. Also, body params are not inclued in the return value of getValidatedParams(), which was confusing. We should prohibit "body" parameters in the return value of getParamSettings(). This could be enforced by RestStructureTest. Before we can do that, we need to update extensions that are now returning bodyparams from getParaSettings. CheckUser, ReportIncident, and WikimediaCampaignEvents are already correctly using getBodyParamSettings. [] fix CampaignEvents [] fix ReadingLists [x] fix GrowthExperiments [x] fix FlaggedRevs [] make RestStructureTest fail when "body" parameters are returned from getParamSettings [] remove backwards compatibility code from the default implementation of getBodyParamSettings, so it simply returns an empty array.