Change Details

The ReplicatedBagOStuff was introduced in 2016 as part of Multi-DC preparation for SessionStore (T88634). The idea involved a Redis backend for session store, and a presumed requirement for SessionStore to have to be able to read from the primary DC at all times (`READ_LATEST`). To satisfy the latter, given the current RedisBagOStuff implementation, would require one RedisBag instance that connects to the local pool of Redis instances, and one that connects to the primary DC's pool. Background: <https://wikitech.wikimedia.org/wiki/Performance/Multi-DC_MediaWiki>. The ReplicatedBagOStuff class ended up unused for a numer of reasons: * SessionStore ended up with looser operational requirements (per T270225 and [change 649766](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649766/)) >>! From [SessionManager docs](https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Session_1_1SessionManager.html#details) on doc.wikimedia.org: > * Locally writable data. The data must be writable from both primary and secondary data centres. > * Locally latest reads. Writes must by default be immediately visible […] from web servers in that data centre. > * Replication. The data must be eventually consistent across all data centres. […] This means it is no longer expected to be able to read from the primary DC, also also no longer expected to send writes or deletes directly to the primary DC. Thus, removing the need for the two-bag wrapper. * (T254634 and T91820) ChronologyProtector and temporary routing cookies "stick" the browser to the primary DC during DB writes. The majority of session writes are also expected to happen via the primary DC, thus by the time a browser unsticks, replication should have completed. If use cases exist that write to the session from a secondary DC request (i.e. GET), they may not rely on immediate chronology between this and a subsequent POST request (per the above requirements). * SessionStore moved from Redis to Kask/Cassandra. The `db-replicated` cache ID was introduced in 2015 as part of Multi-DC preparation for MainStash DB (T88493). It ended up redundant with CACHE_DB when the MainStash DB was finalised in 2022 (T212129) because: * The built-in SqlBagOStuff was improved to support re-using the main Rdbms-LoadBalancer object, and this is also the default now. * The requirements for MainStash (documented in MainSchemaConfig.php#MainStash) allow reads to be stale when performed in a secondary DC. This removed the need for direct reads from the primary DC. * Even at WMF scale we do not currently anticipate a need to separate reads from writes in terms of MainStash load on DBs. This removes the need for SqlBag to obtain separate write connections and read connections, and thus removes the need to configure a "replica" and "primary" instance. ** In in terms of hypothetical future needs, if load separation were needed, we still don't need ReplicatedBagOStuff, since SqlBagOStuff has built-in capabilities already both to shard across mutiple servers (like for ParserCache), or to leverage $wgLBFactoryConf via Rdbms-LoadBalancer, and define a primary DB and one or more replicas, which SqlBagOStuff could then be tweaked to make use of when it obtains connections. ### Scope of work * [ ] Remove `db-replicated` without deprecation (public references go via MainStash instead, unaffected). * [ ] Deprecate `ReplicatedBagOStuff`. * [ ] Remove `ReplicatedBagOStuff`.

The ReplicatedBagOStuff was introduced in 2016 as part of Multi-DC preparation for SessionStore (T88634). The idea involved a Redis backend for session store, and a presumed requirement for SessionStore to have to be able to read from the primary DC at all times (`READ_LATEST`). To satisfy the latter, given the current RedisBagOStuff implementation, would require one RedisBag instance that connects to the local pool of Redis instances, and one that connects to the primary DC's pool. Background: <https://wikitech.wikimedia.org/wiki/Performance/Multi-DC_MediaWiki>. The ReplicatedBagOStuff class ended up unused [1] for a numer of reasons: * SessionStore ended up with looser operational requirements (per T270225 and [change 649766](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649766/)) >>! From [SessionManager docs](https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Session_1_1SessionManager.html#details) on doc.wikimedia.org: > * Locally writable data. The data must be writable from both primary and secondary data centres. > * Locally latest reads. Writes must by default be immediately visible […] from web servers in that data centre. > * Replication. The data must be eventually consistent across all data centres. […] This means it is no longer expected to be able to read from the primary DC, also also no longer expected to send writes or deletes directly to the primary DC. Thus, removing the need for the two-bag wrapper. * (T254634 and T91820) ChronologyProtector and temporary routing cookies "stick" the browser to the primary DC during DB writes. The majority of session writes are also expected to happen via the primary DC, thus by the time a browser unsticks, replication should have completed. If use cases exist that write to the session from a secondary DC request (i.e. GET), they may not rely on immediate chronology between this and a subsequent POST request (per the above requirements). * SessionStore moved from Redis to Kask/Cassandra. The `db-replicated` cache ID was introduced in 2015 as part of Multi-DC preparation for MainStash DB (T88493). It ended up redundant with CACHE_DB when the MainStash DB was finalised in 2022 (T212129) because: * The built-in SqlBagOStuff was improved to support re-using the main Rdbms-LoadBalancer object, and this is also the default now. * The requirements for MainStash (documented in MainSchemaConfig.php#MainStash) allow reads to be stale when performed in a secondary DC. This removed the need for direct reads from the primary DC. * Even at WMF scale we do not currently anticipate a need to separate reads from writes in terms of MainStash load on DBs. This removes the need for SqlBag to obtain separate write connections and read connections, and thus removes the need to configure a "replica" and "primary" instance. ** In in terms of hypothetical future needs, if load separation were needed, we still don't need ReplicatedBagOStuff, since SqlBagOStuff has built-in capabilities already both to shard across mutiple servers (like for ParserCache), or to leverage $wgLBFactoryConf via Rdbms-LoadBalancer, and define a primary DB and one or more replicas, which SqlBagOStuff could then be tweaked to make use of when it obtains connections. ### Scope of work * [ ] Remove `db-replicated` without deprecation (public references go via MainStash instead, unaffected). * [ ] Deprecate `ReplicatedBagOStuff`. * [ ] Remove `ReplicatedBagOStuff`. ### Reflist [1] https://codesearch.wmcloud.org/search/?q=ReplicatedBagOStuff&files=&excludeFiles=&repos= (no known usage in core).

The ReplicatedBagOStuff was introduced in 2016 as part of Multi-DC preparation for SessionStore (T88634). The idea involved a Redis backend for session store, and a presumed requirement for SessionStore to have to be able to read from the primary DC at all times (`READ_LATEST`). To satisfy the latter, given the current RedisBagOStuff implementation, would require one RedisBag instance that connects to the local pool of Redis instances, and one that connects to the primary DC's pool. Background: <https://wikitech.wikimedia.org/wiki/Performance/Multi-DC_MediaWiki>. The ReplicatedBagOStuff class ended up unused [1] for a numer of reasons: * SessionStore ended up with looser operational requirements (per T270225 and [change 649766](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649766/)) >>! From [SessionManager docs](https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Session_1_1SessionManager.html#details) on doc.wikimedia.org: > * Locally writable data. The data must be writable from both primary and secondary data centres. > * Locally latest reads. Writes must by default be immediately visible […] from web servers in that data centre. > * Replication. The data must be eventually consistent across all data centres. […] This means it is no longer expected to be able to read from the primary DC, also also no longer expected to send writes or deletes directly to the primary DC. Thus, removing the need for the two-bag wrapper. * (T254634 and T91820) ChronologyProtector and temporary routing cookies "stick" the browser to the primary DC during DB writes. The majority of session writes are also expected to happen via the primary DC, thus by the time a browser unsticks, replication should have completed. If use cases exist that write to the session from a secondary DC request (i.e. GET), they may not rely on immediate chronology between this and a subsequent POST request (per the above requirements). * SessionStore moved from Redis to Kask/Cassandra. The `db-replicated` cache ID was introduced in 2015 as part of Multi-DC preparation for MainStash DB (T88493). It ended up redundant with CACHE_DB when the MainStash DB was finalised in 2022 (T212129) because: * The built-in SqlBagOStuff was improved to support re-using the main Rdbms-LoadBalancer object, and this is also the default now. * The requirements for MainStash (documented in MainSchemaConfig.php#MainStash) allow reads to be stale when performed in a secondary DC. This removed the need for direct reads from the primary DC. * Even at WMF scale we do not currently anticipate a need to separate reads from writes in terms of MainStash load on DBs. This removes the need for SqlBag to obtain separate write connections and read connections, and thus removes the need to configure a "replica" and "primary" instance. ** In in terms of hypothetical future needs, if load separation were needed, we still don't need ReplicatedBagOStuff, since SqlBagOStuff has built-in capabilities already both to shard across mutiple servers (like for ParserCache), or to leverage $wgLBFactoryConf via Rdbms-LoadBalancer, and define a primary DB and one or more replicas, which SqlBagOStuff could then be tweaked to make use of when it obtains connections. ### Scope of work * [ ] Remove `db-replicated` without deprecation (public references go via MainStash instead, unaffected). * [ ] Deprecate `ReplicatedBagOStuff`. * [ ] Remove `ReplicatedBagOStuff`. ### Reflist [1] https://codesearch.wmcloud.org/search/?q=ReplicatedBagOStuff&files=&excludeFiles=&repos= (no known usage in core).