Change Details

[x] 54 [[https://doc.wikimedia.org/mediawiki-core/master/php/GlobalFunctions_8php.html#a46345f25555fd93d272119932fbfc18f|wfGetDB()]] (use LoadBalancer::getConnection() on an injected instance of LoadBalancer instead) - ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/858444/ | gerrit:858444]]) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classRecentChange.html#ae494a187d8d3adc3c641db04aeb06d83|$rc->getTitle()]] (use getPage() instead) - [[ https://codesearch.wmcloud.org/search/?q=getTitle%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/994988 | gerrit:994988]]) [] [[https://doc.wikimedia.org/mediawiki-core/master/php/classArticle.html#a5be006a9f50f394de766b2d432542c23|$article->mParserOutput]] - [[https://codesearch.wmcloud.org/search/?q=mParserOutput&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/994989|gerrit:994989]]) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1User_1_1User.html#a8750285ae0a36329d5c69eba0c5a5eac|User::newFromID()]] - [[https://codesearch.wmcloud.org/search/?q=newFromID%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] (0 calls) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#a7ab30637d6f7940aaf73b66f322f5fa8|$page->doDeleteArticleReal()]] (Use DeletePage instead. Calling ::deleteIfAllowed and letting DeletePage handle permission checks is preferred over doing permission checks yourself and then calling ::deleteUnsafe. Note that DeletePage returns a good status with false value in case of scheduled deletion, instead of a status with a warning. Also, the new method doesn't have an $error parameter, since any error is added to the returned Status.) - [[https://codesearch.wmcloud.org/search/?q=doDeleteArticleReal%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] (fixed in [[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/997932 | gerrit:997932]]) [] [[https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#a9aeff9c38d314ecb631af379213094dc|$page->doUserEditContent()]] (use PageUpdater::saveRevision instead. Note that the new method expects callers to take care of checking EDIT_MINOR against the minoredit right, and to apply the autopatrol right as appropriate.) - [[https://codesearch.wmcloud.org/search/?q=doUserEditContent%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1006100 | gerrit:1006100]]) [] Add these to static code analyzer CI? to prevent these from coming back Note: Refactoring will be safer once we have some happy path Selenium tests up and running (T320924)

[x] 54 [[https://doc.wikimedia.org/mediawiki-core/master/php/GlobalFunctions_8php.html#a46345f25555fd93d272119932fbfc18f|wfGetDB()]] (use LoadBalancer::getConnection() on an injected instance of LoadBalancer instead) - ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/858444/ | gerrit:858444]]) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classRecentChange.html#ae494a187d8d3adc3c641db04aeb06d83|$rc->getTitle()]] (use getPage() instead) - [[ https://codesearch.wmcloud.org/search/?q=getTitle%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/994988 | gerrit:994988]]) [] [[https://doc.wikimedia.org/mediawiki-core/master/php/classArticle.html#a5be006a9f50f394de766b2d432542c23|$article->mParserOutput]] - [[https://codesearch.wmcloud.org/search/?q=mParserOutput&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/994989|gerrit:994989]]) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1User_1_1User.html#a8750285ae0a36329d5c69eba0c5a5eac|User::newFromID()]] - [[https://codesearch.wmcloud.org/search/?q=newFromID%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] (0 calls) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#a7ab30637d6f7940aaf73b66f322f5fa8|$page->doDeleteArticleReal()]] (Use DeletePage instead. Calling ::deleteIfAllowed and letting DeletePage handle permission checks is preferred over doing permission checks yourself and then calling ::deleteUnsafe. Note that DeletePage returns a good status with false value in case of scheduled deletion, instead of a status with a warning. Also, the new method doesn't have an $error parameter, since any error is added to the returned Status.) - [[https://codesearch.wmcloud.org/search/?q=doDeleteArticleReal%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] (fixed in [[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/997932 | gerrit:997932]]) [x] [[https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#a9aeff9c38d314ecb631af379213094dc|$page->doUserEditContent()]] (use PageUpdater::saveRevision instead. Note that the new method expects callers to take care of checking EDIT_MINOR against the minoredit right, and to apply the autopatrol right as appropriate.) - [[https://codesearch.wmcloud.org/search/?q=doUserEditContent%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage | Codesearch ]] ([[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1006100 | gerrit:1006100]]) [] Add these to static code analyzer CI? to prevent these from coming back Note: Refactoring will be safer once we have some happy path Selenium tests up and running (T320924)