NOTE: Fixing VisualEditor to appear in night mode will be done as part of T366737
== Background
Once OOUI is updated to use the latest version of the Codex design tokens (v1.5 or later), many elements/widgets will be able to automatically adapt to dark mode if MediaWiki users opt in to the alternate color scheme. By default any element which already has the notheme class will get light mode.
For various experiences, where we already enabled night theme for the page, such as https://en.wikipedia.org/wiki/Special:Categories this will result in a dark theme where icons are not legible.
However, OOUI icons currently remain black even on dark backgrounds.
Below is a screenshot of Visual Editor in dark mode if the notheme class is removed (T366737). Many elements of the interface correctly switch colors, but icons in the toolbar remain dark.
{F54253590}
== User story
As a reader I must be able to see all icons in dark mode.
==== Acceptance Criteria
- [ ] OOUI icons should not appear white on white in the VisualEditor toolbar (note fixing VisualEditor will occur in T366737)
- [ ] OOUI icons should be inverted in dark mode.
- [ ] Progressive icons should never be inverted
- [ ] Destructive icons should never be inverted
- [ ] Elements which use the notheme class to restrict display to light mode, should not be impacted by the change. e.g. icons inside desktop Echo overlay
- [ ] Elements which use the skin-invert class to restrict display to light mode, should not be impacted by the change. e.g. icons inside mobile Echo overlay
- [ ] Fix needs to apply to Vector and Minerva
- [ ] Any icons that are broken that are not using standard classes for progressive/destructive icons; not using notheme or skin-invert class should be considered out of scope for sign off of this ticket, and new tickets should be created.
== Communication criteria - does this need an announcement or discussion?
N/A
== Rollback plan
N/A - beta feature.
//This task was created by Version 1.0.0 of the [[ https://mediawiki.org/w/index.php?title=Reading/Web/Request_process | Web team task template ]] using [[ https://phabulous.toolforge.org/ | phabulous ]] //