Change Details

In `profile::service_proxy::envoy` the `uses_ingress` option adds the TLS SNI setting to the TLS connections to the backend services. In T339890 the ML team used the option to force the TLS SNI to connect a service to Thanos Swift (via local envoy proxy), but the naming is not ideal since there is no (Istio) ingress involved. My proposal is to rename `uses_ingress` to `sets_sni`. This is not an easy work since we'll need to support both for some time, to allow all charts to migrate away from it. [x] Puppet change to allow the new setting: https://gerrit.wikimedia.org/r/c/operations/puppet/+/956379 [x] Deployment-charts change to modify the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/956441 [x] Fix to the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/968248 [ ] Rollout of the mesh module change (**mesh.configuration >= 1.4.3**) to all charts (+ deployment) - all done already apart from: [ ] apartium mesh.configuration:1.3 [ ] blubberoid mesh.configuration:1.3 [ ] Removal of the old option

In `profile::service_proxy::envoy` the `uses_ingress` option adds the TLS SNI setting to the TLS connections to the backend services. In T339890 the ML team used the option to force the TLS SNI to connect a service to Thanos Swift (via local envoy proxy), but the naming is not ideal since there is no (Istio) ingress involved. My proposal is to rename `uses_ingress` to `sets_sni`. This is not an easy work since we'll need to support both for some time, to allow all charts to migrate away from it. [x] Puppet change to allow the new setting: https://gerrit.wikimedia.org/r/c/operations/puppet/+/956379 [x] Deployment-charts change to modify the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/956441 [x] Fix to the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/968248 [x] Rollout of the mesh module change (**mesh.configuration >= 1.4.3**) to all charts (+ deployment) - all done already apart from: [x] apartium mesh.configuration:1.3 [x] blubberoid mesh.configuration:1.3 [ ] Removal of the old option

In `profile::service_proxy::envoy` the `uses_ingress` option adds the TLS SNI setting to the TLS connections to the backend services. In T339890 the ML team used the option to force the TLS SNI to connect a service to Thanos Swift (via local envoy proxy), but the naming is not ideal since there is no (Istio) ingress involved. My proposal is to rename `uses_ingress` to `sets_sni`. This is not an easy work since we'll need to support both for some time, to allow all charts to migrate away from it. [x] Puppet change to allow the new setting: https://gerrit.wikimedia.org/r/c/operations/puppet/+/956379 [x] Deployment-charts change to modify the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/956441 [x] Fix to the mesh module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/968248 [ x] Rollout of the mesh module change (**mesh.configuration >= 1.4.3**) to all charts (+ deployment) - all done already apart from: [ x] apartium mesh.configuration:1.3 [ x] blubberoid mesh.configuration:1.3 [ ] Removal of the old option