Change Details

* The UseCase Validators should contain the context keys and “rebuild” the context array rather than passing the Validation Validor’s context straight in to the UseCaseError Things to consider once task complete: * We could create UseCase level validators for commonly validated request data * Could create namespaces for similar use cases (e.g. Item / Property use cases) and the common UseCase validators could live in each of those namespaces

The `context` array from the //Application Validators// is often passed directly into the `UseCaseError` that is thrown by a //UseCase Validator// - for example in the [GetItemStatementsValidator](https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/82191e5fab306fd9e0856fdf8abc3a97fbc68607/repo/rest-api/src/Application/UseCases/GetItemStatements/GetItemStatementsValidator.php#L54). This results in the `Application/Validation` namespace effecting the error context the route handlers return. Instead the //UseCase Validators// should declare `context` keys as constants and “rebuild” the `context` array when creating the `UseCaseError`s to throw in order to keep the `Application/Validation` namespace isolated from the //RouteHandlers//. Things to consider once task complete: * Should we create use case level validators for commonly validated request data? * Should we create namespaces for similar groups of use cases (e.g. Item / Property use cases) ? * Common use case validators could live in each of those namespaces

* The UseCase Validators should contain the context keys and “rebuild” the context array rather than passing the Validation Validor’s context straight in to the UseCaseErrorThe `context` array from the //Application Validators// is often passed directly into the `UseCaseError` that is thrown by a //UseCase Validator// - for example in the [GetItemStatementsValidator](https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/82191e5fab306fd9e0856fdf8abc3a97fbc68607/repo/rest-api/src/Application/UseCases/GetItemStatements/GetItemStatementsValidator.php#L54). This results in the `Application/Validation` namespace effecting the error context the route handlers return. Instead the //UseCase Validators// should declare `context` keys as constants and “rebuild” the `context` array when creating the `UseCaseError`s to throw in order to keep the `Application/Validation` namespace isolated from the //RouteHandlers//. Things to consider once task complete: * We c* Should we create UseCaseuse case level validators for commonly validated request data? * C* Should we create namespaces for similar groups of use cases (e.g. Item / Property use cases) and the c? * Common UseCaseuse case validators could live in each of those namespaces