We shall fix some issues with extant Netbox reports:
[x] Figure out a clean way to omit the single KVM device we have from the PuppetDB report
[x] Probably drop warnings from PuppetDB report
[x] Blacklist sites esams and knams (for now) from Coherence reports
[x] Blacklist certain roles (at least Cable management, Storage bin, Optical device; possible others) from serial number checks
[x] Add check for devices with Status: Offline, that have row/rack assigned
[x] Add check for devices with Status not in (Offline, Planned) but with no row/rack assigned (Update: there are 43 devices that are Status: Inventory but clearly in storage; not sure how we want to handle this right now)
[x] Make asset tag and task checking needs a bit smarter (e.g. catch cases like ticket: `T2`). Should probably check for WMF\d{4,} and T\d{5,} or something.
[x] Change log_info and log lines to log_success if they are infact successes so we can have some nice green lines even if they are summaries.
[x] Message improvements (inconsistent trailing period, missing purchase date" vs. "serial missing" vs. "bad procurement ticket: None", s/bad/malformed/ etc.)
[x] Add a PuppetDB sub-report that checks the device type vs. the `productname` fact. Same for `manufacturer` but that has extra gotchas (Dell's is self-reported "Dell Inc."; HP was renamed to "HPE" at some point).
[ ] Filter out ADMIN_down Ganeti VMs from the PuppetDB report.
The plan is to enable an alert for these reports once we get them to only error on actual errors.