Change Details

When looking at edits in `mediawiki_history` I found a number of edits made using the iOS app that were not tagged as `ios app edit` in column `revision_tags`- after researching these edits by revision_id I found that they were all made by users with `iPadOS` Tablet values in their `useragent` [[ https://docs.google.com/spreadsheets/d/1VD-v5bkbbdhT0Wzv1NEVzFldsqkA3lZbB0t8mwTWDxk/edit#gid=659227453 | data ]]. It looks like the Mobile app extension that adds the `ios app edit` tag is not set up to assign iPadOS edits to `ios app edit`category. This issue After discussion it was proposed that instead of changing the Mobile app extension to recognize iPadOS we could instead append iOS to the WikipediaApp/`version` value that is sent with `useragent` data. Also noting here that the value for `os_family` in useragent is still (and has been) assigned to iOS even for events originating from iPadOS so we can see them in our internal data. However that filter is applied it is able to recognize iOS devices both Phone and Tablet.

When looking at edits in `mediawiki_history` I found a number of edits made using the iOS app that were not tagged as `ios app edit` in column `revision_tags`- after researching these edits by revision_id I found that they were all made by users with `iPadOS` Tablet values in their `useragent` [[ https://docs.google.com/spreadsheets/d/1VD-v5bkbbdhT0Wzv1NEVzFldsqkA3lZbB0t8mwTWDxk/edit#gid=659227453 | data ]]. It looks like the Mobile app extension that adds the `ios app edit` tag is not set up to assign iPadOS edits to `ios app edit`category. This issue After discussion it was proposed that instead of changing the Mobile app extension to recognize iPadOS we could instead append iOS to the WikipediaApp/`version` value that is sent with `useragent` data. Also noting here that the value for `os_family` in useragent is still (and has been) assigned to iOS even for events originating from iPadOS so we can see them in our internal data. However that filter is applied it is able to recognize iOS devices both Phone and Tablet. ==== Engineering Notes ==== Android hardcodes "Android" into their user agent name, so we should do the same. We should swap out `systemName` with a hardcoded `iOS` to fix any backend logic targeting the string "iOS". We already have "Phone" and "Tablet" at the end so that will provide us extra context about iPhone vs iPad.

When looking at edits in `mediawiki_history` I found a number of edits made using the iOS app that were not tagged as `ios app edit` in column `revision_tags`- after researching these edits by revision_id I found that they were all made by users with `iPadOS` Tablet values in their `useragent` [[ https://docs.google.com/spreadsheets/d/1VD-v5bkbbdhT0Wzv1NEVzFldsqkA3lZbB0t8mwTWDxk/edit#gid=659227453 | data ]]. It looks like the Mobile app extension that adds the `ios app edit` tag is not set up to assign iPadOS edits to `ios app edit`category. This issue After discussion it was proposed that instead of changing the Mobile app extension to recognize iPadOS we could instead append iOS to the WikipediaApp/`version` value that is sent with `useragent` data. Also noting here that the value for `os_family` in useragent is still (and has been) assigned to iOS even for events originating from iPadOS so we can see them in our internal data. However that filter is applied it is able to recognize iOS devices both Phone and Tablet. ==== Engineering Notes ==== Android hardcodes "Android" into their user agent name, so we should do the same. We should swap out `systemName` with a hardcoded `iOS` to fix any backend logic targeting the string "iOS". We already have "Phone" and "Tablet" at the end so that will provide us extra context about iPhone vs iPad.