Change Details

After the change of cache architecture, we meet T294675 and [[https://gerrit.wikimedia.org/r/c/737698|Change the way of fetching global preferences]]. But there is another problem: if the default preference was set in the form descriptor and a local exception was set, the Special:GlobalPreferences page can't reflect the global one. This affected one field provided by core: [[https://gerrit.wikimedia.org/g/mediawiki/core/+/fd3020b8cd968a866db3a93dbabe9436e7efb785/includes/preferences/DefaultPreferencesFactory.php#988|timecorrection]]. Provide default value by form descriptor is valid and extensions may also have some use cases. I think we can Convert the GlobalPreferences\Storage class to GlobalUserOptionsManager or something compatible with UserOptionsManager, then inject it to GlobalPreferencesFactory lively (before the call to `parent::getFormDescriptor()` and restore the default one later).

After [[https://gerrit.wikimedia.org/r/c/mediawiki/core/+/699466|the change of cache architecture]], we meet T294675 and [[https://gerrit.wikimedia.org/r/c/737698|Change the way of fetching global preferences]]. But there is another problem: if the default preference was set in the form descriptor and a local exception was set, the Special:GlobalPreferences page can't reflect the global one. This affected one field provided by core: [[https://gerrit.wikimedia.org/g/mediawiki/core/+/fd3020b8cd968a866db3a93dbabe9436e7efb785/includes/preferences/DefaultPreferencesFactory.php#988|timecorrection]]. Provide default value by form descriptor is valid and extensions may also have some use cases. I think we can Convert the GlobalPreferences\Storage class to GlobalUserOptionsManager or something compatible with UserOptionsManager, then inject it to GlobalPreferencesFactory lively (before the call to `parent::getFormDescriptor()` and restore the default one later).

After [[https://gerrit.wikimedia.org/r/c/mediawiki/core/+/699466|the change of cache architecture]], we meet T294675 and [[https://gerrit.wikimedia.org/r/c/737698|Change the way of fetching global preferences]]. But there is another problem: if the default preference was set in the form descriptor and a local exception was set, the Special:GlobalPreferences page can't reflect the global one. This affected one field provided by core: [[https://gerrit.wikimedia.org/g/mediawiki/core/+/fd3020b8cd968a866db3a93dbabe9436e7efb785/includes/preferences/DefaultPreferencesFactory.php#988|timecorrection]]. Provide default value by form descriptor is valid and extensions may also have some use cases. I think we can Convert the GlobalPreferences\Storage class to GlobalUserOptionsManager or something compatible with UserOptionsManager, then inject it to GlobalPreferencesFactory lively (before the call to `parent::getFormDescriptor()` and restore the default one later).