Change Details

From code review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/708713, we decided that these issues are not blockers: > A couple of problems with activating the "Add topic" tab (adding 'selected' class in ReplyLinksController): > 1. The "Create source" tab should be deactivated, like the "Read" tab > 2. (In fact, should "Create source" tab even be activated when the page loads with our empty state? That's probably a core bug…) > 3. The "Add topic" tab should be activated when clicking the custom button too – I think this is actually a pre-existing issue in my code affecting all extra buttons, but I only noticed now

From code review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/708713, we decided that these issues are not blockers: > A couple of problems with activating the "Add topic" tab (adding 'selected' class in ReplyLinksController): > 1. The "Create source" tab should be deactivated, like the "Read" tab > 2. (In fact, should "Create source" tab even be activated when the page loads with our empty state? That's probably a core bug…) > 3. The "Add topic" tab should be activated when clicking the custom button too – I think this is actually a pre-existing issue in my code affecting all extra buttons, but I only noticed now ### Test instructions 1. Go to a non-existent talk page ** "Create source" tab should not be active {F34620955} 2. Click the "Start a discussion" button ** "Add topic" tab should be active {F34620958}

From code review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/708713, we decided that these issues are not blockers: > A couple of problems with activating the "Add topic" tab (adding 'selected' class in ReplyLinksController): > 1. The "Create source" tab should be deactivated, like the "Read" tab > 2. (In fact, should "Create source" tab even be activated when the page loads with our empty state? That's probably a core bug…) > 3. The "Add topic" tab should be activated when clicking the custom button too – I think this is actually a pre-existing issue in my code affecting all extra buttons, but I only noticed now ### Test instructions 1. Go to a non-existent talk page ** "Create source" tab should not be active {F34620955} 2. Click the "Start a discussion" button ** "Add topic" tab should be active {F34620958}