Change Details

The bit on the account creation form should be done as a SecondaryAuthenticationProvider, instead of the deprecated 'AddNewAccount' hook and the horribleness you're doing with the 'BeforePageDisplay' hook. The fields could be displayed on the initial login form (by returning the AuthenticationRequest defining your custom fields from `getAuthenticationRequests()`) or on a secondary page during the account creation process (by returning it with a UI response from your `beginSecondaryAccountCreation()`).

The bit on the account creation form should be done as a SecondaryAuthenticationProvider, instead of the deprecated 'AddNewAccount' hook and the horribleness you're doing with the 'BeforePageDisplay' hook. The fields could be displayed on the initial login form (by returning the AuthenticationRequest defining your custom fields from `getAuthenticationRequests()`) or on a secondary page during the account creation process (by returning it with a UI response from your `beginSecondaryAccountCreation()`). Also, your tests that the current special page is 'Userlogin' may need to check for 'CreateAccount' as well or instead.

The bit on the account creation form should be done as a SecondaryAuthenticationProvider, instead of the deprecated 'AddNewAccount' hook and the horribleness you're doing with the 'BeforePageDisplay' hook. The fields could be displayed on the initial login form (by returning the AuthenticationRequest defining your custom fields from `getAuthenticationRequests()`) or on a secondary page during the account creation process (by returning it with a UI response from your `beginSecondaryAccountCreation()`). Also, your tests that the current special page is 'Userlogin' may need to check for 'CreateAccount' as well or instead.