Change Details

While [[ [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/730618 | URL ]] | refactoring skins ]], we have encountered a problem with two existing Skin methods, which were introduced to support Special:MediaSearch in adda9c0555 (T273879) which is blocking the work there. It's used in one place here: https://gerrit.wikimedia.org/g/mediawiki/extensions/MediaSearch/+/4d96a28b3f735f54c29526eec4ed0c1432878471/src/MediaSearchHooks.php#46 What the search page is out of the scope of concerns of the Skin and we would like to remove this as part of the refactor task. The way we typically allow alteration of pages, is 1) via message keys via the WikimediaMessages extension (See MediaWiki:portal-url and MediaWiki:privacypage ) or 2) configuration variable (where the setting is made on site level). 3) Alternatively, this should be a method higher up the change on OutputPage Happy to work with you to find a better approach to doing this.

While [[ [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/730618 | URL ]] | refactoring skins ]], we have encountered a problem with two existing Skin methods, which were introduced to support Special:MediaSearch in adda9c0555 (T273879) which is blocking the work there. It's used in one place here: https://gerrit.wikimedia.org/g/mediawiki/extensions/MediaSearch/+/4d96a28b3f735f54c29526eec4ed0c1432878471/src/MediaSearchHooks.php#46 What the search page is out of the scope of concerns of the Skin and we would like to remove this as part of the refactor task. The way we typically allow alteration of pages, is 1) via message keys via the WikimediaMessages extension (See MediaWiki:portal-url and MediaWiki:privacypage ) or 2) configuration variable (where the setting is made on site level). 3) Alternatively, this should be a method higher up the change e.g. OutputPage or SpecialSearch Happy to work with you to find a better approach to doing this.

While [[ [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/730618 | URL ]] | refactoring skins ]], we have encountered a problem with two existing Skin methods, which were introduced to support Special:MediaSearch in adda9c0555 (T273879) which is blocking the work there. It's used in one place here: https://gerrit.wikimedia.org/g/mediawiki/extensions/MediaSearch/+/4d96a28b3f735f54c29526eec4ed0c1432878471/src/MediaSearchHooks.php#46 What the search page is out of the scope of concerns of the Skin and we would like to remove this as part of the refactor task. The way we typically allow alteration of pages, is 1) via message keys via the WikimediaMessages extension (See MediaWiki:portal-url and MediaWiki:privacypage ) or 2) configuration variable (where the setting is made on site level). 3) Alternatively, this should be a method higher up the change one.g. OutputPagee or SpecialSearch Happy to work with you to find a better approach to doing this.