Change Details

Currently PHPcs MediaWiki rule set does not complains about type annotations like `@return boolean` or `@return integer` even if the common PHP convention is to write `@return bool` and `@return int`. It might be nice to add a rule to flag similar common mistakes.

Currently MediaWIki PHPcs sniff `FunctionCommentSniff` only validates `@return` annotations of methods with a body. It does not complain about annotations like `@return boolean` or `@return integer` that should be written `@return bool` and `@return int`. See, e.g. https://github.com/wikimedia/mediawiki-extensions-ProofreadPage/blob/3ae6d26ae1b0e6511052eea5bb49baa26c09df6b/includes/Pagination/Pagination.php#L25 The relevant line in `FunctionCommentSniff` is: https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/5f813f727ee47d5c90981b44e82f0c5a0263e933/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php#L198

Currently PHPcs MediaWiki rule set does not complains about typeMediaWIki PHPcs sniff `FunctionCommentSniff` only validates `@return` annotations of methods with a body. It does not complain about annotations like `@return boolean` or `@return integer` even if the common PHP convention is tothat should be writetten `@return bool` and `@return int`. It might be nice to add a rule to flag similar common mistakes.See, e.g. https://github.com/wikimedia/mediawiki-extensions-ProofreadPage/blob/3ae6d26ae1b0e6511052eea5bb49baa26c09df6b/includes/Pagination/Pagination.php#L25 The relevant line in `FunctionCommentSniff` is: https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/5f813f727ee47d5c90981b44e82f0c5a0263e933/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php#L198