Change Details

Have an article cache controller that performs the duties of caching an article should a user tap the bookmark icon throughout the app. 1. Article cache controller will fetch mobile-html & mobile-html-offline-resources and cache the response via FileManager. Remove cache when user toggles bookmark icon off. Keep track of cache via PersistentCacheItem & PersistentCacheGroup Core Data objects, similar to CacheItem & CacheGroup manner that current ImageController uses. Only delete resource if it is not shared by another article. [DONE] 2. Have SchemeHandler attempt to pull from URLCache.shared for happy path. If nothing comes from URLCache, try fetching with session. If that fails (i.e. connection error), try pulling from persistent cache via Article Cache Controller. [DONE] 3. Ensure caching process can continue if ArticleViewController is deallocated. [DONE but with singleton, would like to rework if possible]. 4. Ensure caching process can recover (or database is cleaned out and user is notified) if pieces of the saving fails (i.e. they tap bookmark without a connection, let it try again when a connection restores). In general do an error handling/todo audit on all of this. 5. Make general enough so other things can use this caching system, not just articles. [DONE, stretch goal is we could subclass CacheController and write a StandardCacheController that say, the diffing endpoint could refer to that DiffController hooks into upon fetching.] 6. Save ETAG in caching and send in the request header so we can lean on server-side caching. It is ok if coming from the state restoration state is stale as we want them to see data as quickly as possible. 7. Set excludeFromBackup when setting up caching directory so that user is in a consistent state when migrating to a new device. 8. When pulling from cache via SchemeHandler, be sure to take full URLRequest as input to consider variant logic.

Have an article cache controller that performs the duties of caching an article should a user tap the bookmark icon throughout the app. 1. Article cache controller will fetch mobile-html & mobile-html-offline-resources and cache the response via FileManager. Remove cache when user toggles bookmark icon off. Keep track of cache via PersistentCacheItem & PersistentCacheGroup Core Data objects, similar to CacheItem & CacheGroup manner that current ImageController uses. Only delete resource if it is not shared by another article. [DONE] 2. Have SchemeHandler attempt to pull from URLCache.shared for happy path. If nothing comes from URLCache, try fetching with session. If that fails (i.e. connection error), try pulling from persistent cache via Article Cache Controller. [DONE] 3. Ensure caching process can continue if ArticleViewController is deallocated. [DONE but with singleton, would like to rework if possible]. 4. Ensure caching process can recover (or database is cleaned out and user is notified) if pieces of the saving fails (i.e. they tap bookmark without a connection, let it try again when a connection restores). In general do an error handling/todo audit on all of this. 5. Make general enough so other things can use this caching system, not just articles. [DONE, stretch goal is we could subclass CacheController and write a StandardCacheController that say, the diffing endpoint could refer to that DiffController hooks into upon fetching.] 6. Save ETAG in caching and send in the request header so we can lean on server-side caching. It is ok if coming from the state restoration state is stale as we want them to see data as quickly as possible. 7. Set excludeFromBackup when setting up caching directory so that user is in a consistent state when migrating to a new device. 8. When pulling from cache via SchemeHandler, be sure to take full URLRequest as input to consider variant logic. 9. After SchemeHandler changes, test other areas of app that lean on it to be sure we didn't break anything (SectionEditorViewController, PreviewWebViewViewController, AboutViewController)

Have an article cache controller that performs the duties of caching an article should a user tap the bookmark icon throughout the app. 1. Article cache controller will fetch mobile-html & mobile-html-offline-resources and cache the response via FileManager. Remove cache when user toggles bookmark icon off. Keep track of cache via PersistentCacheItem & PersistentCacheGroup Core Data objects, similar to CacheItem & CacheGroup manner that current ImageController uses. Only delete resource if it is not shared by another article. [DONE] 2. Have SchemeHandler attempt to pull from URLCache.shared for happy path. If nothing comes from URLCache, try fetching with session. If that fails (i.e. connection error), try pulling from persistent cache via Article Cache Controller. [DONE] 3. Ensure caching process can continue if ArticleViewController is deallocated. [DONE but with singleton, would like to rework if possible]. 4. Ensure caching process can recover (or database is cleaned out and user is notified) if pieces of the saving fails (i.e. they tap bookmark without a connection, let it try again when a connection restores). In general do an error handling/todo audit on all of this. 5. Make general enough so other things can use this caching system, not just articles. [DONE, stretch goal is we could subclass CacheController and write a StandardCacheController that say, the diffing endpoint could refer to that DiffController hooks into upon fetching.] 6. Save ETAG in caching and send in the request header so we can lean on server-side caching. It is ok if coming from the state restoration state is stale as we want them to see data as quickly as possible. 7. Set excludeFromBackup when setting up caching directory so that user is in a consistent state when migrating to a new device. 8. When pulling from cache via SchemeHandler, be sure to take full URLRequest as input to consider variant logic. 9. After SchemeHandler changes, test other areas of app that lean on it to be sure we didn't break anything (SectionEditorViewController, PreviewWebViewViewController, AboutViewController)