Change Details

Because the impact module is rendered on the client side we need to have a skeleton or loading state to display before the JavaScript can execute. {F35629724} **Acceptance Criteria** # I should see a skeleton or loading state that doesn't cause the module box to grow in size when the JavaScript executes. # .... #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.

Because the impact module is rendered on the client side we need to have a skeleton or loading state to display before the JavaScript can execute. | Current (no loading state) | Proposed design |--|-- | {F35629724} | TBC **Acceptance Criteria** # I should see a skeleton or loading state that doesn't cause the module box to grow in size when the JavaScript executes. # .... #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.

Because the impact module is rendered on the client side we need to have a skeleton or loading state to display before the JavaScript can execute. | Current (no loading state) | Proposed design |--|-- | {F35629724} | TBC **Acceptance Criteria** # I should see a skeleton or loading state that doesn't cause the module box to grow in size when the JavaScript executes. # .... #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.