Change Details

The EntityRevisionLookup service in Multi/SingleEntitySourceServices (DataAccessServices) should be migrated to the new service wiring files in repo and client respectively. This will allow us to stop passing a SingleEntitySourceServicesFactory into PrefetchingTermLookupFactory, and will finally allow us to remove the SingleEntitySourceServiceFactory service (T277731). EntityRevisionLookup is bound to one entity source, so the service we migrate should be a kind of EntityRevisionLookupFactory, which is given an entity source (or its database name?) and returns a EntityRevisionLookup.

The EntityRevisionLookup service in Multi/SingleEntitySourceServices (DataAccessServices) should be migrated to the new service wiring files in repo and client respectively. (See [[ https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_services.html | docs ]] on how to migrate services into the new service container) This will allow us to stop passing a SingleEntitySourceServicesFactory into PrefetchingTermLookupFactory, and will finally allow us to remove the SingleEntitySourceServiceFactory service (T277731). The SingleEntitySourceServices method getEntityRevisionLookup is bound to one entity source, so we might want to also create a kind of EntityRevisionLookupFactory, which is given an entity source (or its database name?) and returns a EntityRevisionLookup.

The EntityRevisionLookup service in Multi/SingleEntitySourceServices (DataAccessServices) should be migrated to the new service wiring files in repo and client respectively. This will allow us to stop passing a SingleEntitySourceServicesFactory into PrefetchingTermLookupFactory, and will finally allow us to remove the SingleEntitySourceServiceFactory service (T277731).(See [[ https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_services.html | docs ]] on how to migrate services into the new service container) This will allow us to stop passing a SingleEntitySourceServicesFactory into PrefetchingTermLookupFactory, and will finally allow us to remove the SingleEntitySourceServiceFactory service (T277731). The SingleEntitySourceServices method getEntityRevisionLookup is bound to one entity source, so the service we migrate should beso we might want to also create a kind of EntityRevisionLookupFactory, which is given an entity source (or its database name?) and returns a EntityRevisionLookup.