Page MenuHomePhabricator
Create Task
Maniphest T103780

Syntaxhighlight no longer supports enclose="div" for line wrapping
Closed, ResolvedPublic
Actions

Description

Wrapping content within <syntaxhighlight lang="html5" enclose="div"> </syntaxhighlight> no longer recognizes the enclosure, the language and even inline css style settings.

First noticed this happening on Wikisource today (1.26wmf11 yesterday) & verified the same on testsite2.

Please verify by visiting:

Details

SubjectRepoBranchLines +/-
Revert "Remove obsolete mw-highlighter styles"mediawiki/extensions/SyntaxHighlight_GeSHimaster+7 -0
Remove 'direction: ltr' from 'pre' stylesmediawiki/coremaster+3 -5
Remove 'direction: ltr' from 'pre' stylesmediawiki/corewmf/1.26wmf11+3 -5
Wrap lines in <pre> and .mw-code by defaultmediawiki/coremaster+5 -0
Wrap lines in <pre> and .mw-code by defaultmediawiki/corewmf/1.26wmf11+5 -0
Remove obsolete mw-highlighter stylesmediawiki/extensions/SyntaxHighlight_GeSHimaster+0 -7
Add white-space: pre-wrap to .mw-highlightmediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -0
Customize query in gerrit

Revisions and Commits

rESHG extension-SyntaxHighlight_GeSHi
rESHGfd1b3b38b70c Document the 'enclose' and 'inline' parser tag attributes

Related Objects

Event Timeline

GOIII created this task.Jun 25 2015, 3:19 AM
GOIII raised the priority of this task from to Unbreak Now!.
GOIII updated the task description. (Show Details)
GOIII added a project: SyntaxHighlight.
GOIII added subscribers: GOIII, TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2015, 3:19 AM
GOIII set Security to None.Jun 25 2015, 3:30 AM
GOIII added subscribers: • MZMcBride, ori, matmarex.
GOIII added a comment.Jun 25 2015, 3:33 AM
In T103585, @MZMcBride wrote:

http://en.wikipedia.beta.wmflabs.org/wiki/Python

enclose="div" should wrap long lines. This worked in the GeSHi-backed extension and seems to have broken with the switch to Pygments.

GOIII merged a task: T103585: SyntaxHighlight_GeSHi's enclose="div" not wrapping long lines after switch to Pygments.Jun 25 2015, 3:36 AM
Krinkle claimed this task.Jun 25 2015, 3:41 AM
Krinkle renamed this task from Syntaxhighlight tags no longer recognizing inline settings to Syntaxhighlight no longer supports enclose="div" for line wrapping.Jun 25 2015, 3:45 AM
Krinkle added a project: Regression.
gerritbot subscribed.Jun 25 2015, 4:20 AM

Change 220699 had a related patch set uploaded (by Ori.livneh):
Add white-space: pre-wrap to .mw-highlight

https://gerrit.wikimedia.org/r/220699

gerritbot added a project: Patch-For-Review.Jun 25 2015, 4:20 AM
gerritbot added a comment.Jun 25 2015, 4:22 AM

Change 220700 had a related patch set uploaded (by Krinkle):
Re-introduce support for enclose="div"

https://gerrit.wikimedia.org/r/220700

GOIII added a comment.EditedJun 25 2015, 4:38 AM
In T103780#1398963, @gerritbot wrote:

Change 220699 had a related patch set uploaded (by Ori.livneh):
Add white-space: pre-wrap to .mw-highlight

https://gerrit.wikimedia.org/r/220699

Err... I added that css locally and it did nothing. Shouldn't it be. . .

.mw-highlight .mw-code, .mw-highlight pre {
    white-space: pre-wrap;
}

... though that assumes enclose=div is the default state???

gerritbot added a comment.Jun 25 2015, 4:38 AM

Change 220701 had a related patch set uploaded (by Krinkle):
Wrap lines in pre and .mw-code by default

https://gerrit.wikimedia.org/r/220701

gerritbot added a comment.Jun 25 2015, 4:40 AM

Change 220702 had a related patch set uploaded (by Krinkle):
Remove obsolete mw-highlighter styles

https://gerrit.wikimedia.org/r/220702

GOIII added a comment.Jun 25 2015, 4:46 AM
In T103780#1398970, @gerritbot wrote:

Change 220702 had a related patch set uploaded (by Krinkle):
Remove obsolete mw-highlighter styles

https://gerrit.wikimedia.org/r/220702

there is also an unnecessary background-color setting in pygments.generated.css, Line 3, as well

gerritbot added a comment.Jun 25 2015, 4:52 AM

Change 220699 abandoned by Krinkle:
Add white-space: pre-wrap to .mw-highlight

Reason:
Yep. Coordinated with Ori already. Superseded by Icd8b9bd56d6abc7b64c.

https://gerrit.wikimedia.org/r/220699

TheDJ added a comment.Jun 25 2015, 5:49 AM

ehm, wait, why did we just remove the force ltr ? We just added it to fix the blocks in rt. languages ....

gerritbot added a comment.Jun 25 2015, 6:51 AM

Change 220702 merged by jenkins-bot:
Remove obsolete mw-highlighter styles

https://gerrit.wikimedia.org/r/220702

Krinkle mentioned this in rMEXTb610fc03c29d: Updated mediawiki/extensions Project….Jun 25 2015, 6:51 AM
Krinkle mentioned this in rESHGf834b719b99c: Remove obsolete mw-highlighter styles.
gerritbot added a comment.Jun 25 2015, 7:00 AM

Change 220701 merged by jenkins-bot:
Wrap lines in <pre> and .mw-code by default

https://gerrit.wikimedia.org/r/220701

Krinkle mentioned this in rMW054b1c9e3cd8: Wrap lines in <pre> and .mw-code by default.Jun 25 2015, 7:00 AM
• Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 25 2015, 7:00 AM
• Forrestbot subscribed.
• Forrestbot added a project: MW-1.26-release.Jun 25 2015, 8:00 AM
gerritbot added a comment.Jun 25 2015, 8:21 AM

Change 220720 had a related patch set uploaded (by Ori.livneh):
Wrap lines in <pre> and .mw-code by default

https://gerrit.wikimedia.org/r/220720

gerritbot added a comment.Jun 25 2015, 8:31 AM

Change 220720 merged by Ori.livneh:
Wrap lines in <pre> and .mw-code by default

https://gerrit.wikimedia.org/r/220720

ori mentioned this in rMW1de6e00ad4e3: Wrap lines in <pre> and .mw-code by default.Jun 25 2015, 8:31 AM
ori added a comment.Jun 25 2015, 8:35 AM
In T103780#1399087, @TheDJ wrote:

ehm, wait, why did we just remove the force ltr ? We just added it to fix the blocks in rt. languages ....

Because it's done in core now: https://gerrit.wikimedia.org/r/#/c/220720/1/resources/src/mediawiki.skinning/elements.css

ori closed this task as Resolved.Jun 25 2015, 8:36 AM

Thanks Timo.

• Forrestbot added a project: WMF-deploy-2015-06-23_(1.26wmf11).Jun 25 2015, 9:00 AM
TheDJ added a comment.Jun 25 2015, 10:23 AM
In T103780#1399435, @ori wrote:
In T103780#1399087, @TheDJ wrote:

ehm, wait, why did we just remove the force ltr ? We just added it to fix the blocks in rt. languages ....

Because it's done in core now: https://gerrit.wikimedia.org/r/#/c/220720/1/resources/src/mediawiki.skinning/elements.css

Ehm, the pre wrap I can understand, but forcing the direction on all <pre> elements ?
Even starting a line with a ' ' in wikitext will then force you into ltr mode, that doesn't seem correct to me.

matmarex added a comment.Jun 25 2015, 10:55 AM

It is most definitely not correct.

matmarex reopened this task as Open.Jun 25 2015, 11:05 AM
gerritbot added a comment.Jun 25 2015, 11:06 AM

Change 220738 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Remove obsolete mw-highlighter styles"

https://gerrit.wikimedia.org/r/220738

gerritbot added a comment.Jun 25 2015, 11:08 AM

Change 220739 had a related patch set uploaded (by Bartosz Dziewoński):
Remove 'direction: ltr' from 'pre' styles

https://gerrit.wikimedia.org/r/220739

matmarex mentioned this in T2260: Vector: Handle <pre> overflow with a scrollbar or wrapping.Jun 25 2015, 11:12 AM
gerritbot added a comment.Jun 25 2015, 5:03 PM

Change 220823 had a related patch set uploaded (by Ori.livneh):
Remove 'direction: ltr' from 'pre' styles

https://gerrit.wikimedia.org/r/220823

gerritbot added a comment.Jun 25 2015, 5:07 PM

Change 220739 merged by jenkins-bot:
Remove 'direction: ltr' from 'pre' styles

https://gerrit.wikimedia.org/r/220739

matmarex mentioned this in rMW9abf45ce39a5: Remove 'direction: ltr' from 'pre' styles.Jun 25 2015, 5:07 PM
gerritbot added a comment.Jun 25 2015, 5:11 PM

Change 220823 merged by jenkins-bot:
Remove 'direction: ltr' from 'pre' styles

https://gerrit.wikimedia.org/r/220823

ori mentioned this in rMW30d187ad1c69: Remove 'direction: ltr' from 'pre' styles.Jun 25 2015, 5:12 PM
gerritbot added a comment.Jun 25 2015, 5:15 PM

Change 220738 merged by jenkins-bot:
Revert "Remove obsolete mw-highlighter styles"

https://gerrit.wikimedia.org/r/220738

matmarex mentioned this in rMEXT692cc17bf446: Updated mediawiki/extensions Project….Jun 25 2015, 5:15 PM
matmarex mentioned this in rESHGca778d0a9903: Revert "Remove obsolete mw-highlighter styles".
Krinkle closed this task as Resolved.Jun 25 2015, 6:07 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
matmarex mentioned this in T85794: Convert SyntaxHighlight_Geshi from Geshi to Pygments (was: Don't register 250+ modules).Jun 30 2015, 8:57 PM
Ricordisamoa subscribed.Jun 30 2015, 9:01 PM
matmarex added a comment.Jun 30 2015, 9:14 PM

Summary for future readers, as the flurry of patches above is all but readable: this was resolved by making all HTML <pre/> tags render with line wrapping in MediaWiki core (something we wanted to do for a long time – T2260 – but couldn't due to conflicts between GeSHi and Tidy), removing the need for <syntaxhighlight enclose=div> support.

Krinkle added a commit: rESHGfd1b3b38b70c: Document the 'enclose' and 'inline' parser tag attributes.Apr 28 2016, 2:18 AM
Restricted Application added subscribers: Southparkfan, Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptApr 28 2016, 2:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL